Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965651AbbLPAFX (ORCPT ); Tue, 15 Dec 2015 19:05:23 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36139 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965571AbbLPAFV (ORCPT ); Tue, 15 Dec 2015 19:05:21 -0500 Message-ID: <5670AAB2.1080102@gmail.com> Date: Tue, 15 Dec 2015 16:05:06 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Eric Anholt , "Rafael J. Wysocki" CC: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , Kevin Hilman , Ulf Hansson , Greg Kroah-Hartman , Alexander Aring , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell Subject: Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver References: <1450215622-27394-1-git-send-email-eric@anholt.net> <1450215622-27394-3-git-send-email-eric@anholt.net> <567093CD.1020208@gmail.com> <87oadrmfmi.fsf@eliezer.anholt.net> In-Reply-To: <87oadrmfmi.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2512 Lines: 56 On 15/12/15 15:55, Eric Anholt wrote: > Florian Fainelli writes: > >> On 15/12/15 13:40, Eric Anholt wrote: >>> From: Alexander Aring >>> >>> This patch adds support for several power domains on Raspberry Pi, >>> including USB (so it can be enabled even if the bootloader didn't do >>> it), and graphics. >>> >>> This patch is the combined work of Eric Anholt (who wrote USB support >>> inside of the Raspberry Pi firmware driver, and wrote the non-USB >>> domain support) and Alexander Aring (who separated the original USB >>> work out from the firmware driver). >>> >>> Signed-off-by: Alexander Aring >>> Signed-off-by: Eric Anholt >>> --- >>> >>> v2: Add support for power domains other than USB, using the new >>> firmware interface, reword commit message (changes by Eric) >>> >>> v3: Restructure as a builtin driver, and drop >>> of_genpd_add_provider_onecell error handling to avoid >>> pm_genpd_exit() dependency until that API can be settled. Clean >>> up copyright header, add missing ISP initialization, and fix typo >>> in transposer's name. >>> >>> arch/arm/mach-bcm/Kconfig | 10 ++ >>> arch/arm/mach-bcm/Makefile | 1 + >>> arch/arm/mach-bcm/raspberrypi-power.c | 247 ++++++++++++++++++++++++++++ >>> include/dt-bindings/arm/raspberrypi-power.h | 41 +++++ >>> 4 files changed, 299 insertions(+) >>> create mode 100644 arch/arm/mach-bcm/raspberrypi-power.c >> >> What motivated the location of this power domain driver in >> arch/arm/mach-bcm? Should not we have this in drivers/power/ or >> somewhere in drivers/ at the very least? > > ls stronly suggests that power contains drivers for power supplies and > batteries, not power domains. There are 6 power domain drivers in > arch/arm, 3 in drivers/clk, and 3 in drivers/soc. If we ever have to support a different architecture which happens to use a similar power domain, then we want it to be in a location which makes it easy for sharing it in the first place. As it stands today, it does not seem useful to me to have this code in arch/arm/mach-bcm/ at all. Maybe there is room from a drivers/power/domains/ of some kind? -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/