Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933934AbbLPCt0 (ORCPT ); Tue, 15 Dec 2015 21:49:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:48650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbbLPCtZ (ORCPT ); Tue, 15 Dec 2015 21:49:25 -0500 Date: Tue, 15 Dec 2015 18:49:22 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] f2fs: introduce new option for controlling data flush Message-ID: <20151216024922.GA71308@jaegeuk.local> References: <00fa01d136fa$7c028980$74079c80$@samsung.com> <20151215220238.GC66113@jaegeuk.local> <013501d137aa$f069ab40$d13d01c0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <013501d137aa$f069ab40$d13d01c0$@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1795 Lines: 65 Hi Chao, On Wed, Dec 16, 2015 at 10:38:27AM +0800, Chao Yu wrote: ... > > > +++ b/fs/f2fs/super.c > > > @@ -67,6 +67,7 @@ enum { > > > Opt_extent_cache, > > > Opt_noextent_cache, > > > Opt_noinline_data, > > > + Opt_data_flush, > > > > Need Opt_nodata_flush too. > > We need this unless we set data_flush as a default option. Is that right? I meant both of them. Thanks, > > Thanks, > > > > > Thanks, > > > > > Opt_nodiscard, > > > Opt_err, > > > }; > > > @@ -92,6 +93,7 @@ static match_table_t f2fs_tokens = { > > > {Opt_extent_cache, "extent_cache"}, > > > {Opt_noextent_cache, "noextent_cache"}, > > > {Opt_noinline_data, "noinline_data"}, > > > + {Opt_data_flush, "data_flush"}, > > > {Opt_nodiscard, "nodiscard"}, > > > {Opt_err, NULL}, > > > }; > > > @@ -411,6 +413,9 @@ static int parse_options(struct super_block *sb, char *options) > > > case Opt_noinline_data: > > > clear_opt(sbi, INLINE_DATA); > > > break; > > > + case Opt_data_flush: > > > + clear_opt(sbi, DATA_FLUSH); > > > + break; > > > default: > > > f2fs_msg(sb, KERN_ERR, > > > "Unrecognized mount option \"%s\" or missing value", > > > @@ -694,6 +699,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root) > > > seq_puts(seq, ",extent_cache"); > > > else > > > seq_puts(seq, ",noextent_cache"); > > > + if (test_opt(sbi, DATA_FLUSH)) > > > + seq_puts(seq, ",data_flush"); > > > seq_printf(seq, ",active_logs=%u", sbi->active_logs); > > > > > > return 0; > > > -- > > > 2.6.3 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/