Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbbLPGIs (ORCPT ); Wed, 16 Dec 2015 01:08:48 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:32935 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbLPGIr (ORCPT ); Wed, 16 Dec 2015 01:08:47 -0500 From: Daniel Axtens To: Zhang Zhuoyu , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tglx@linutronix.de, jiang.liu@linux.intel.com, zhangzhuoyu@cmss.chinamobile.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() In-Reply-To: <1450242896-8322-1-git-send-email-hellozzy1988@126.com> References: <1450242896-8322-1-git-send-email-hellozzy1988@126.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 16 Dec 2015 17:08:41 +1100 Message-ID: <878u4vapsm.fsf@gamma.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1589 Lines: 56 Hi, A couple of things. Firstly, your two email addresses don't match: Zhang Zhuoyu writes: > From: Zhang Zhuoyu These lines do seem odd! Are they causing a problem? I'd be more comfortable removing them if I understood why they were added. But they've been around since the beginning of git history so that could be a bit difficult. Instead, would it be possible to make sure this doesn't break anything by including some test results? Thanks, Daniel > Remove paradoxical and unnecessary lines before disable local interrupt. > > Signed-off-by: Zhang Zhuoyu > --- > arch/powerpc/kernel/irq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c > index 290559d..03fa686 100644 > --- a/arch/powerpc/kernel/irq.c > +++ b/arch/powerpc/kernel/irq.c > @@ -454,8 +454,6 @@ void migrate_irqs(void) > > free_cpumask_var(mask); > > - local_irq_enable(); > - mdelay(1); > local_irq_disable(); > } > #endif > -- > 1.8.3.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/