Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933822AbbLPIGT (ORCPT ); Wed, 16 Dec 2015 03:06:19 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:32851 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932664AbbLPIGP (ORCPT ); Wed, 16 Dec 2015 03:06:15 -0500 Message-ID: <1450253097.21989.78.camel@gmail.com> Subject: Re: [PATCH v5] serial: support for 16550A serial ports on LP-8x4x From: Sergei Ianovich To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Alan Cox , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , Heikki Krogerus , Andy Shevchenko , Scott Wood , Masahiro Yamada , Sebastian Andrzej Siewior , Paul Burton , Joachim Eastwood , Mans Rullgard , Paul Gortmaker , Peter Hurley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" Date: Wed, 16 Dec 2015 11:04:57 +0300 In-Reply-To: <1970812.j9fZPC5F1b@wuerfel> References: <1397668667-27328-1-git-send-email-ynvich@gmail.com> <1450213494-21884-1-git-send-email-ynvich@gmail.com> <1970812.j9fZPC5F1b@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2250 Lines: 66 On Tue, 2015-12-15 at 22:51 +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:04:45 Sergei Ianovich wrote: > > index 0000000..5f9a4c1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/lp8x4x-serial.txt > > @@ -0,0 +1,35 @@ > > +UART ports on ICP DAS LP-8x4x > > + > > +ICP DAS LP-8x4x contains three additional serial ports interfaced > > via > > +Analog Devices ADM213EA chips in addition to 3 serial ports on PXA > > CPU. > > + > > +Required properties: > > +- compatible : should be "icpdas,uart-lp8x4x" > > Compatible strings should not include a 'x' wildcard like this, better > use > the specific chip name. > > Also, it sounds like you named them after the board vendor, which > sounds > wrong as the vendor part of the compatible string should be the > whoever > made that part (analog?) The chips themselves are standard, they would work with 8250_core if properly connected. However, they are not connected normally. Al least some of their config pins are wired to a different address region. So the driver is board-specific. 'x' wildcards in the name of the board seem important. There are devices made by the same vendor without 8 or 4 in their name. Those devices either are not shipped with linux or are base on a x86 platform. Does this justify the choice of the compatible string? > > +- reg : should provide 16 byte man IO memory region and 1 byte > > region for > > +       termios > > + > > +- interrupts : should provide interrupt > > + > > +- interrupt-parent : should provide a link to interrupt controller > > either > > +                    explicitly or implicitly from a parent node > > interrupt-parent should be an optional property, or you can leave it > out, > as this is a standard property that can always be there when there is > interrupts. ok > > +Examples (from pxa27x-lp8x4x.dts): > > + > > +               uart@9050 { > > By convention, the name should be 'serial', not 'uart'. ok -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/