Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbbLPLQW (ORCPT ); Wed, 16 Dec 2015 06:16:22 -0500 Received: from foss.arm.com ([217.140.101.70]:54751 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754575AbbLPLQV (ORCPT ); Wed, 16 Dec 2015 06:16:21 -0500 Message-ID: <567147CD.6090404@arm.com> Date: Wed, 16 Dec 2015 11:15:25 +0000 From: James Morse User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Andrew Pinski CC: Catalin Marinas , LKML , "linux-arm-kernel@lists.infradead.org" , Andrew Pinski , Ming Lei , Will Deacon , David Daney Subject: Re: [PATCH 1/2] arm64: Improve error reporting on set_pte_at() checks References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 39 Hi Andrew, On 16/12/15 03:01, Andrew Pinski wrote: > On Tue, Dec 9, 2015 at 17:26:56, Catalin Marinas > wrote: >> >> Currently the BUG_ON() checks do not give enough information about the PTEs being set. This patch changes BUG_ON to WARN_ONCE and dumps the values of the old and new PTEs. > > > This change broke building the mantis driver: > > In file included from ./arch/arm64/include/asm/io.h:30:0, > from drivers/media/pci/mantis/mantis_i2c.c:21: > ./arch/arm64/include/asm/pgtable.h: In function ‘set_pte_at’: > ./arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration > of function ‘BUILD_BUG_ON_INVALID’ > [-Werror=implicit-function-declaration] > VM_WARN_ONCE(!pte_young(pte), > ^ This is due to a missing include in include/linux/mmdebug.h, which Julien Grall saw with CONFIG_XEN & !CONFIG_DEBUG_VM. There was some discussion at [0], and a patch at [1]. The quick-and-dirty workaround is to toggle CONFIG_DEBUG_VM. It should be fixed in the next rc. Thanks, James [0] https://lkml.org/lkml/2015/12/14/489 [1] http://www.spinics.net/lists/linux-mm/msg98868.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/