Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965716AbbLPLW1 (ORCPT ); Wed, 16 Dec 2015 06:22:27 -0500 Received: from mail-vk0-f50.google.com ([209.85.213.50]:36209 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965635AbbLPLWZ (ORCPT ); Wed, 16 Dec 2015 06:22:25 -0500 MIME-Version: 1.0 In-Reply-To: <1450260553.7981.14.camel@mtksdaap41> References: <1450238356-36319-1-git-send-email-dawei.chien@mediatek.com> <1450238356-36319-3-git-send-email-dawei.chien@mediatek.com> <1450260553.7981.14.camel@mtksdaap41> From: Daniel Kurtz Date: Wed, 16 Dec 2015 19:22:04 +0800 X-Google-Sender-Auth: bqLFeisqvOpw1oMu8bXVPOnFftw Message-ID: Subject: Re: [PATCH v5 2/3] arm64: dts: mt8173: Add thermal zone node. To: dawei chien Cc: Viresh Kumar , "Rafael J. Wysocki" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matthias Brugger , Sascha Hauer , Daniel Lezcano , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream , Sascha Hauer , Punit Agrawal Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 55 On Wed, Dec 16, 2015 at 6:09 PM, dawei chien wrote: > On Wed, 2015-12-16 at 16:34 +0800, Daniel Kurtz wrote: >> On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien wrote: >> > >> > This adds thermal zone node to Mediatek MT8173 dtsi file. >> > >> > Signed-off-by: Dawei Chien >> > --- >> > This patch is base on patchset: >> > https://lkml.org/lkml/2015/11/30/239 >> > --- >> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ >> > 1 file changed, 43 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > index fda805d..4114cee 100644 >> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > @@ -188,6 +188,49 @@ >> > clock-output-names = "cpum_ck"; >> > }; >> > >> > + thermal-zones { >> > + cpu_thermal: cpu_thermal { >> > + polling-delay-passive = <1000>; /* milliseconds */ >> > + polling-delay = <1000>; /* milliseconds */ >> > + >> > + thermal-sensors = <&thermal 0>; >> >> This should be <&thermal> with the MTK temp sensor node in >> https://lkml.org/lkml/2015/11/30/239 patch series. >> >> -Dan > > Hi Dan, > Sascha's thermal driver V12 only register sensor id as 0, so we need to > register sensor id as 0 to device tree as well. > > Either <&thermal 0> or <&thermal>, sensor id should be 0 for two cases. > I try this two case, function all work fine for two cases. May I have > any misunderstand? Please kindly give your comment. > I will re-send this patch again once you tell me the reason, thank you. In the new patchset, Sascha changed it to: #thermal-sensor-cells = <0>; Which means the <&thermal> phandle no longer has any arguments. Thanks! -Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/