Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934222AbbLPPvQ (ORCPT ); Wed, 16 Dec 2015 10:51:16 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:55665 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932613AbbLPPvO (ORCPT ); Wed, 16 Dec 2015 10:51:14 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Yury Norov , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, Andrew Pinski , jan.dakinevich@gmail.com, Andrew Pinski , ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 10/20] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads Date: Wed, 16 Dec 2015 16:50:18 +0100 Message-ID: <12007390.0rtOQc0npd@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1450215766-14765-11-git-send-email-ynorov@caviumnetworks.com> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-11-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:zpJ8v0VuXOlmWWQk+aLBxjrqhYL9g3JGnp0XbhfVoEi0K+xAXl9 k/FQj3iliJJAUqM1alAvfHEfFCaa0YaEYofzHIilIgYPGTW+u9wUImL6ov2BI78Rw2yCQQo 4YFFTfzH53gfvTpiCDbKfN7IRKdvhaYe/AkxC6fwFfDzuXzRGxAuo3v204trhV4thRA34Hf V6lnQm3DiaNWWt3M6uXUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:0MMbV79B6bo=:kMGDh+8L4e8mEMjMateeqs 9YnpIBgKTZFvM062B2oU0SlHH8+yjgSGlqESiKRz8531nvA9LsBgmkz2GJoQ+hn92jj1MiTFr l9zN5tYXslvkeWg4Erz839YPjUX9QKg1CiTguWmpm6gkWIHwDUoJ5A5vIZ52CZFYs9fktTgdF qpz69/56C3sja/EmRASoJgw0SohTPr8WcqeTq6+pyEs0IETFen0lPH9w2mAFfk8nHMY8qwzUh HfyPVrd76FAu1ftvrKJWjJSAm9CzCYKTHPgHNjkoui9B9X/MZ+ayJqeqEwqAd87our8BbcNjt vS6XxuHb52nE215TciID4KXq+gPGmE7OyKOc6ogWzmOqHS2RjQIPjqdDbRC68BWYy5OQzu8wz 7Jt16zi77w8IkIknMWEvxJub3ac36vuGEg1dRbfsP2EeC/t+jEvGhZfj/EsdI6Y8YccKPtwNK +HXYBsFEk2HofQ4RCYBYhD72+5kFTA2uBY29BT74mJj10dc5RsbpTVMsXTovY+YXNYqT3pAn5 ZMFUmFyaOIV5YJ54VLKxqj4dQTgDJB1vcl1rOVzm3wCiV+DY49Uf+7DCQVuP4UFFG63+6t2+N 1yVHaLAPtvp0brkIg7rcAmyKZc13J6B/qv7Lxy4d2o8vIyT/GfyoNPxG6ipCFRlbDbVhUyJFL U37zUv+HXonKx2fmJq0UaoomtsCicgJZhy9C+aP6RpdS1GSceUqD3GNJB5ncAq3vsrkQJxk1X S0p4YGx04WNb1mAR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 19 On Wednesday 16 December 2015 00:42:36 Yury Norov wrote: > +#ifdef CONFIG_ARM64_ILP32 > + /* ILP32 threads are started the same way as LP64 threads. */ > + if (is_ilp32_compat_task()) { > + start_thread(regs, pc, sp); > + return; > + } > +#endif > Just a small style comment, but I think you can just leave out the #ifdef, as is_ilp32_compat_task() will already return false if that is disabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/