Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966081AbbLPQ47 (ORCPT ); Wed, 16 Dec 2015 11:56:59 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:54025 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965972AbbLPQ44 (ORCPT ); Wed, 16 Dec 2015 11:56:56 -0500 Subject: Re: [PATCH RESEND v3 0/9] Add STM32 pinctrl/GPIO driver To: Maxime Coquelin , Linus Walleij , Mark Rutland , Rob Herring , , References: <1449822306-9035-1-git-send-email-mcoquelin.stm32@gmail.com> CC: , , , , Daniel Thompson , From: Patrice Chotard Message-ID: <567197A7.5000903@st.com> Date: Wed, 16 Dec 2015 17:56:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449822306-9035-1-git-send-email-mcoquelin.stm32@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.153] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21,1.0.33,0.0.0000 definitions=2015-12-16_07:2015-12-16,2015-12-16,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3462 Lines: 90 Hi Maxime You can add my Acked-by after fixing the patch 4/9 Thanks Patrice On 12/11/2015 09:24 AM, Maxime Coquelin wrote: > Hi Linus, Patrice, > > I resend the series for Patrice to review it. > > Thanks, > Maxime > > > > This is the third round of STM32 pinctrl series, which improves DT > bindings declaration and documentation, and also fixes some commit fixup > issues. The series also contains two more patches, adding GPIO LEDs > support as a user of this driver. > > The STM32 family has 16 pins per GPIO bank, and the number of bank varies > depending on the model. > > Pins can be multiplexed either in GPIO mode, alternate function (up to 15 > functions per pin) or analog (for ADC/DAC). > > Changes since v2: > ----------------- > - Rebase on v4.4-rc1 > - Declare leds also for Eval board > - Set green led as heartbeat > - Collect some acks > > Changes since v1: > ----------------- > - Add GPIO LEDs support in DT and defconfig > - Changes pinmux DT bindings from macros to raw values (Daniel) > - Improve DT bindings documentation (Daniel) > - Fix some commit fixup and rebase issues. > > Kind regards, > Maxime > > Maxime Coquelin (9): > ARM: Kconfig: Introduce MACH_STM32F429 flag > Documentation: dt-bindings: Document STM32 pinctrl driver DT bindings > includes: dt-bindings: Add STM32F429 pinctrl DT bindings > pinctrl: Add STM32 MCUs support > ARM: mach-stm32: Select pinctrl > ARM: dts: Add pinctrl node to STM32F429 > ARM: dts: Add USART1 pin config to STM32F429 boards > ARM: dts: Add leds support to STM32F429 boards > ARM: config: Enable GPIO Led driver in stm32_defconfig > > .../bindings/pinctrl/st,stm32-pinctrl.txt | 126 ++ > arch/arm/Kconfig | 6 + > arch/arm/boot/dts/stm32429i-eval.dts | 19 + > arch/arm/boot/dts/stm32f429-disco.dts | 13 + > arch/arm/boot/dts/stm32f429.dtsi | 110 ++ > arch/arm/configs/stm32_defconfig | 1 + > drivers/pinctrl/Kconfig | 1 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/stm32/Kconfig | 16 + > drivers/pinctrl/stm32/Makefile | 5 + > drivers/pinctrl/stm32/pinctrl-stm32.c | 856 +++++++++++ > drivers/pinctrl/stm32/pinctrl-stm32.h | 43 + > drivers/pinctrl/stm32/pinctrl-stm32f429.c | 1598 ++++++++++++++++++++ > include/dt-bindings/pinctrl/pinctrl-stm32.h | 12 + > include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1241 +++++++++++++++ > 15 files changed, 4048 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > create mode 100644 drivers/pinctrl/stm32/Kconfig > create mode 100644 drivers/pinctrl/stm32/Makefile > create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.c > create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.h > create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32f429.c > create mode 100644 include/dt-bindings/pinctrl/pinctrl-stm32.h > create mode 100644 include/dt-bindings/pinctrl/stm32f429-pinfunc.h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/