Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966212AbbLPS2n (ORCPT ); Wed, 16 Dec 2015 13:28:43 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:34084 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933086AbbLPS2l (ORCPT ); Wed, 16 Dec 2015 13:28:41 -0500 From: Brian Norris To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, , Brian Norris , Jyri Sarha , Sergej Sawazki Subject: [PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup() Date: Wed, 16 Dec 2015 10:28:31 -0800 Message-Id: <1450290511-14442-1-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.6.0.rc2.230.g3dd15c0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 35 Reported by Coverity. Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()") Signed-off-by: Brian Norris Cc: Jyri Sarha Cc: Sergej Sawazki Cc: Stephen Boyd --- drivers/clk/clk-gpio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c index 335322dc403f..c1baa89cbf91 100644 --- a/drivers/clk/clk-gpio.c +++ b/drivers/clk/clk-gpio.c @@ -294,8 +294,10 @@ static void __init of_gpio_clk_setup(struct device_node *node, num_parents = of_clk_get_parent_count(node); parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL); - if (!parent_names) + if (!parent_names) { + kfree(data); return; + } for (i = 0; i < num_parents; i++) parent_names[i] = of_clk_get_parent_name(node, i); -- 2.6.0.rc2.230.g3dd15c0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/