Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755038AbbLPSlK (ORCPT ); Wed, 16 Dec 2015 13:41:10 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:52089 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbbLPSlI (ORCPT ); Wed, 16 Dec 2015 13:41:08 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 1/3] STAGING: COMEDI: Fixed format of comments in plx9080.h To: =?UTF-8?Q?Moritz_K=c3=b6nig?= , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: Cc: Fabian Lang , linux-kernel@i4.cs.fau.de From: Ian Abbott Message-ID: <5671B03F.2030103@mev.co.uk> Date: Wed, 16 Dec 2015 18:41:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2142 Lines: 60 On 12/12/15 17:09, Moritz König wrote: > This patch fixes the format of comments in plx9080.h. > > Signed-off-by: Moritz König > Signed-off-by: Fabian Lang > --- > drivers/staging/comedi/drivers/plx9080.h | 132 ++++++++++++++++++++++--------- > 1 file changed, 95 insertions(+), 37 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/plx9080.h b/drivers/staging/comedi/drivers/plx9080.h > index 2570653..40514f7 100644 > --- a/drivers/staging/comedi/drivers/plx9080.h > +++ b/drivers/staging/comedi/drivers/plx9080.h > @@ -34,7 +34,8 @@ struct plx_dma_desc { > /* transfer_size is in bytes, only first 23 bits of register are used */ > __le32 transfer_size; > /* address of next descriptor (quad word aligned), plus some > - * additional bits (see PLX_DMA0_DESCRIPTOR_REG) */ > + * additional bits (see PLX_DMA0_DESCRIPTOR_REG) > + */ > __le32 next; We prefer the usual block comment style: /* * Like * this */ > }; > > @@ -46,23 +47,38 @@ struct plx_dma_desc { > ** > **********************************************************************/ > > -#define PLX_LAS0RNG_REG 0x0000 /* L, Local Addr Space 0 Range Register */ > -#define PLX_LAS1RNG_REG 0x00f0 /* L, Local Addr Space 1 Range Register */ > +#define PLX_LAS0RNG_REG 0x0000 /* L, Local Addr Space 0 Range > + * Register > + */ > +#define PLX_LAS1RNG_REG 0x00f0 /* L, Local Addr Space 1 Range > + * Register > + */ I suggest moving such comments that would wrap over 80 columns onto the previous line, like this: /* L, Local Addr Space 0 Range Register */ #define PLX_LAS0RNG_REG 0x0000 /* L, Local Addr Space 1 Range Register */ #define PLX_LAS1RNG_REG 0x00f0 -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/