Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965781AbbLPTAs (ORCPT ); Wed, 16 Dec 2015 14:00:48 -0500 Received: from mail-qk0-f181.google.com ([209.85.220.181]:36660 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755187AbbLPTAr (ORCPT ); Wed, 16 Dec 2015 14:00:47 -0500 MIME-Version: 1.0 In-Reply-To: <1450229928-22006-1-git-send-email-danielmentz@google.com> References: <1450229928-22006-1-git-send-email-danielmentz@google.com> Date: Wed, 16 Dec 2015 11:00:46 -0800 Message-ID: Subject: Re: [PATCH] dma-debug: Fix dma_debug_entry offset calculation From: Dan Williams To: Daniel Mentz Cc: "linux-kernel@vger.kernel.org" , Andrew Morton , Joerg Roedel , Vinod Koul , Russell King , James Bottomley Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 21 On Tue, Dec 15, 2015 at 5:38 PM, Daniel Mentz wrote: > dma-debug uses struct dma_debug_entry to keep track of dma coherent > memory allocation requests. The virtual address is converted into a pfn > and an offset. Previously, the offset was calculated using an incorrect > bit mask. As a result, we saw incorrect error messages from dma-debug > like the following: > > "DMA-API: exceeded 7 overlapping mappings of cacheline 0x03e00000" > > Cacheline 0x03e00000 does not exist on our platform. > > Fixes: 0abdd7a81b7e ("dma-debug: introduce debug_dma_assert_idle()") > Signed-off-by: Daniel Mentz Looks good, thanks Daniel! I'll include this with some other fixes I'm pushing up later today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/