Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755246AbbLPXqb (ORCPT ); Wed, 16 Dec 2015 18:46:31 -0500 Received: from mga02.intel.com ([134.134.136.20]:64282 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbbLPXq3 (ORCPT ); Wed, 16 Dec 2015 18:46:29 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,438,1444719600"; d="scan'208";a="619236594" From: "Pandruvada, Srinivas" To: "edubezval@gmail.com" CC: "Zhang, Rui" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCHv2 1/3] thermal: setup monitor only once after handling trips Thread-Topic: [PATCHv2 1/3] thermal: setup monitor only once after handling trips Thread-Index: AQHROFv4n+z2oOnJYESKi3jdrxCRuA== Date: Wed, 16 Dec 2015 23:46:23 +0000 Message-ID: <1450309514.2912.148.camel@spandruv-desk3.jf.intel.com> References: <1450237754-31906-1-git-send-email-edubezval@gmail.com> <1450237754-31906-2-git-send-email-edubezval@gmail.com> In-Reply-To: <1450237754-31906-2-git-send-email-edubezval@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.199.153] Content-Type: text/plain; charset="utf-8" Content-ID: <80B4F53A2134764CBF9E7B9744B935EC@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBGNkYHY012105 Content-Length: 1675 Lines: 53 On Tue, 2015-12-15 at 19:49 -0800, Eduardo Valentin wrote: > Instead of changing the monitoring setup every time after > handling each trip, this patch simplifies the monitoring > setup by moving the setup call to a place where all > trips have been treated already. > Looks good to me. Thanks, Srinivas > Cc: Zhang Rui > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > V1->V2: > fixed typo > --- > drivers/thermal/thermal_core.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index d9e525c..8fa82c0 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -457,11 +457,6 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) > handle_critical_trips(tz, trip, type); > else > handle_non_critical_trips(tz, trip, type); > - /* > - * Alright, we handled this trip successfully. > - * So, start monitoring again. > - */ > - monitor_thermal_zone(tz); > } > > /** > @@ -547,6 +542,12 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) > > for (count = 0; count < tz->trips; count++) > handle_thermal_trip(tz, count); > + > + /* > + * Alright, we handled these trips successfully. > + * So, start monitoring again. > + */ > + monitor_thermal_zone(tz); > } > EXPORT_SYMBOL_GPL(thermal_zone_device_update); > ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?