Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281AbbLPXrF (ORCPT ); Wed, 16 Dec 2015 18:47:05 -0500 Received: from down.free-electrons.com ([37.187.137.238]:50466 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752805AbbLPXrE (ORCPT ); Wed, 16 Dec 2015 18:47:04 -0500 Date: Thu, 17 Dec 2015 00:47:02 +0100 From: Alexandre Belloni To: Steve Twiss Cc: Alessandro Zummo , LINUXKERNEL , RTC-LINUX , David Dajun Chen , Support Opensource Subject: Re: [PATCH V1] rtc: da9063: access ordering error during RTC interrupt system power on Message-ID: <20151216234702.GK8574@piout.net> References: <20151208163406.B34683FB25@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151208163406.B34683FB25@swsrvapps-01.diasemi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 46 Hi, This seems mostly fine, however ... On 08/12/2015 at 16:28:39 +0000, Steve Twiss wrote : > irq_alarm = platform_get_irq_byname(pdev, "ALARM"); > ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL, > da9063_alarm_event, > IRQF_TRIGGER_LOW | IRQF_ONESHOT, > "ALARM", rtc); > - if (ret) { > + if (ret) > dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n", > irq_alarm, ret); > - return ret; > - } > - ... now that requesting the interrupt is optional, you probably want to prevent userspace from thinking it will get an interrupt after setting the alarm by returning -EINVAL in da9063_rtc_read_alarm() and da9063_rtc_set_alarm() in that case. > - rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, DA9063_DRVNAME_RTC, > - &da9063_rtc_ops, THIS_MODULE); > - if (IS_ERR(rtc->rtc_dev)) > - return PTR_ERR(rtc->rtc_dev); > > - da9063_data_to_tm(data, &rtc->alarm_time, rtc); > - rtc->rtc_sync = false; > return ret; > } > > -- > end-of-patch for PATCH V1 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/