Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934605AbbLQDQe (ORCPT ); Wed, 16 Dec 2015 22:16:34 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:42487 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932239AbbLQDQc (ORCPT ); Wed, 16 Dec 2015 22:16:32 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <96547246eccd6ef1f9e5db3d4ec51763> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56722908.6030200@rock-chips.com> Date: Thu, 17 Dec 2015 11:16:24 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] drm/rockchip: dw_hdmi: use encoder enable function References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <1450321718-31389-1-git-send-email-mark.yao@rock-chips.com> <1450321718-31389-3-git-send-email-mark.yao@rock-chips.com> In-Reply-To: <1450321718-31389-3-git-send-email-mark.yao@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2298 Lines: 64 Sorry, Ops, fat finger, discard this lost thread mail. On 2015年12月17日 11:08, Mark Yao wrote: > encoder.enable is more compatible to atomic api than encoder.prepare/commit > > Signed-off-by: Mark Yao > --- > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index 525b5a8..8e1605c 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -195,12 +195,15 @@ static void dw_hdmi_rockchip_encoder_mode_set(struct drm_encoder *encoder, > { > } > > -static void dw_hdmi_rockchip_encoder_commit(struct drm_encoder *encoder) > +static void dw_hdmi_rockchip_encoder_enable(struct drm_encoder *encoder) > { > struct rockchip_hdmi *hdmi = to_rockchip_hdmi(encoder); > u32 val; > int mux; > > + rockchip_drm_crtc_mode_config(encoder->crtc, DRM_MODE_CONNECTOR_HDMIA, > + ROCKCHIP_OUT_MODE_AAAA); > + > mux = rockchip_drm_encoder_get_mux_id(hdmi->dev->of_node, encoder); > if (mux) > val = HDMI_SEL_VOP_LIT | (HDMI_SEL_VOP_LIT << 16); > @@ -212,17 +215,10 @@ static void dw_hdmi_rockchip_encoder_commit(struct drm_encoder *encoder) > (mux) ? "LIT" : "BIG"); > } > > -static void dw_hdmi_rockchip_encoder_prepare(struct drm_encoder *encoder) > -{ > - rockchip_drm_crtc_mode_config(encoder->crtc, DRM_MODE_CONNECTOR_HDMIA, > - ROCKCHIP_OUT_MODE_AAAA); > -} > - > static struct drm_encoder_helper_funcs dw_hdmi_rockchip_encoder_helper_funcs = { > .mode_fixup = dw_hdmi_rockchip_encoder_mode_fixup, > .mode_set = dw_hdmi_rockchip_encoder_mode_set, > - .prepare = dw_hdmi_rockchip_encoder_prepare, > - .commit = dw_hdmi_rockchip_encoder_commit, > + .enable = dw_hdmi_rockchip_encoder_enable, > .disable = dw_hdmi_rockchip_encoder_disable, > }; > -- Ｍark Yao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/