Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966778AbbLQF02 (ORCPT ); Thu, 17 Dec 2015 00:26:28 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:48396 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753145AbbLQF0Y (ORCPT ); Thu, 17 Dec 2015 00:26:24 -0500 X-Greylist: delayed 515 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Dec 2015 00:26:24 EST Date: Thu, 17 Dec 2015 07:17:42 +0200 From: Baruch Siach To: Eric Anholt Cc: linux-rpi-kernel@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Florian Fainelli , Jason Cooper , Scott Branden , Stephen Warren , Marc Zyngier , Ray Jui , Lee Jones , linux-kernel@vger.kernel.org, Andrea Merello , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Kumar Gala , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836 Message-ID: <20151217051742.GV2318@tarshish> References: <1450310115-22163-1-git-send-email-eric@anholt.net> <1450310115-22163-3-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450310115-22163-3-git-send-email-eric@anholt.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 42 Hi Eric, On Wed, Dec 16, 2015 at 03:55:09PM -0800, Eric Anholt wrote: > @@ -226,6 +228,26 @@ static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = { > .xlate = irq_domain_xlate_onecell > }; > > +#ifdef CONFIG_SMP Why not put this section under the existing '#ifdef CONFIG_SMP' just a few lines above? > +int __init bcm2836_smp_boot_secondary(unsigned int cpu, > + struct task_struct *idle) > +{ > + unsigned long secondary_startup_phys = > + (unsigned long)virt_to_phys((void *)secondary_startup); > + > + dsb(); > + writel(secondary_startup_phys, > + intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu); > + > + return 0; > +} > + > +static const struct smp_operations bcm2836_smp_ops __initconst = { > + .smp_boot_secondary = bcm2836_smp_boot_secondary, > +}; > + > +#endif baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/