Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbbLQF0P (ORCPT ); Thu, 17 Dec 2015 00:26:15 -0500 Received: from g4t3426.houston.hp.com ([15.201.208.54]:20920 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934341AbbLQF0M convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 00:26:12 -0500 From: "Seymour, Shane M" To: Hannes Reinecke , Alexander Duyck CC: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michal Kubecek Subject: RE: [PATCHv2] pci: Update VPD size with correct length Thread-Topic: [PATCHv2] pci: Update VPD size with correct length Thread-Index: AQHRODNgxtiI085vXkmRQ5BYW02uG57OoczA Date: Thu, 17 Dec 2015 05:25:27 +0000 Message-ID: References: <1450262992-77276-1-git-send-email-hare@suse.de> <4468155.Bdxh8senif@lennox.hannes-reinecke.de> <1571929.py3SMrb2RG@lennox.hannes-reinecke.de> In-Reply-To: <1571929.py3SMrb2RG@lennox.hannes-reinecke.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.210.48.21] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 12 > The only 'error' cases I've encountered so far is a read of all zeroes (and a > halting the machine once you've read beyond a certain point) or a read of > 0xff throughout the entire area. So that approach would work for both of them. I should add that I'd tested the previous patch and this patch. I'll retest once v3 is available. I have a card that repeats the vpd data every 4k for all 32k. The patch as it stands truncates that to just the valid data and lspci -vvvv shows the vpd data correctly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/