Subject: Re: [RFC PATCH] lpfc: Add lockdep assertions
To: Johannes Thumshirn <jthumshirn@suse.de>,
        "James E.J. Bottomley" <JBottomley@odin.com>,
        Dick Kennedy <dick.kennedy@avagotech.com>,
        James Smart <james.smart@avagotech.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
References: <1448023037-43391-1-git-send-email-jthumshirn@suse.de>
CC: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Bart Van Assche <bart.vanassche@sandisk.com>
Message-ID: <5672620A.4060104@sandisk.com>
Date: Thu, 17 Dec 2015 08:19:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1448023037-43391-1-git-send-email-jthumshirn@suse.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2015 07:19:40.9196
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0829
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 966
Lines: 27

On 11/20/2015 01:37 PM, Johannes Thumshirn wrote:
> Several functions in lpfc have comments stating that the function must be
> called with the hbalock (or hostlock, or ringlock) held. Add
> lockdep_assert_held() annotations to these functions, so one can actually
> verify the locks are held.
>
> [ ... ]
>
> @@ -2647,6 +2675,7 @@ lpfc_sli_iocbq_lookup(struct lpfc_hba *phba,
>   {
>   	struct lpfc_iocbq *cmd_iocb = NULL;
>   	uint16_t iotag;
> +	lockdep_assert_held(&phba->hbalock);
>
>   	iotag = prspiocb->iocb.ulpIoTag;

(replying to an e-mail of one month ago)

Please leave a blank line after declarations. Checkpatch should have 
reported this. Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/