Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933043AbbLQIkZ (ORCPT ); Thu, 17 Dec 2015 03:40:25 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:43632 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932527AbbLQIkX (ORCPT ); Thu, 17 Dec 2015 03:40:23 -0500 Date: Thu, 17 Dec 2015 16:40:18 +0800 From: Herbert Xu To: LABBE Corentin Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] crypto: niagara: Use precalculated hash from headers Message-ID: <20151217084018.GA9166@gondor.apana.org.au> References: <1450184423-31155-1-git-send-email-clabbe.montjoie@gmail.com> <1450184423-31155-3-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450184423-31155-3-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 33 On Tue, Dec 15, 2015 at 02:00:21PM +0100, LABBE Corentin wrote: > Precalculated hash for empty message are now present in hash headers. > This patch just use them. > > Signed-off-by: LABBE Corentin > --- > drivers/crypto/Kconfig | 2 ++ > drivers/crypto/n2_core.c | 33 ++++++--------------------------- > 2 files changed, 8 insertions(+), 27 deletions(-) > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index b9ec295..dea754b 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -194,6 +194,8 @@ config CRYPTO_DEV_NIAGARA2 > select CRYPTO_DES > select CRYPTO_BLKCIPHER > select CRYPTO_HASH > + select CRYPTO_MD5 > + select CRYPTO_SHA1 Don't we need CRYPTO_SHA256 as well? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/