MIME-Version: 1.0
In-Reply-To: <20151217084809.GC9239@gondor.apana.org.au>
References: <1448039840-11367-1-git-send-email-phil@nwl.cc>
	<20151130093755.GA8159@gondor.apana.org.au>
	<20151130101401.GA17712@orbit.nwl.cc>
	<20151130101859.GA8378@gondor.apana.org.au>
	<20151203124129.GA5505@gondor.apana.org.au>
	<CADvbK_cA5qaooTOE4Z2bGYs+ys17ZajSMgKDVWgctSZWJ0vjpw@mail.gmail.com>
	<20151217084809.GC9239@gondor.apana.org.au>
Date: Thu, 17 Dec 2015 17:00:35 +0800
Message-ID: <CADvbK_df=Z1re2wPUF9JCXggBzRqF=Tgt86PXV0KqBcx3VeVNA@mail.gmail.com>
Subject: Re: rhashtable: Prevent spurious EBUSY errors on insertion
From: Xin Long <lucien.xin@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Phil Sutter <phil@nwl.cc>, davem <davem@davemloft.net>,
        network dev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org,
        tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1189
Lines: 31

On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote:
>>
>> sorry for late test, but unfortunately, my case with rhashtalbe still
>> return EBUSY.
>> I added some debug code in rhashtable_insert_rehash(), and found:
>> *future_tbl is null*
>>
>> fail:
>>         /* Do not fail the insert if someone else did a rehash. */
>>         if (likely(rcu_dereference_raw(tbl->future_tbl))) {
>>                 printk("future_tbl is there\n");
>>                 return 0;
>>         } else {
>>                 printk("future_tbl is null\n");
>>         }
>>
>> any idea why ?
>
> That's presumably because you got a genuine double rehash.
>
> Until you post your code we can't really help you.
>
i wish i could , but my codes is a big patch for sctp, and this issue
happens in a special stress test based on this patch.
im trying to think how i can show you. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/