Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964793AbbLQJgI (ORCPT ); Thu, 17 Dec 2015 04:36:08 -0500 Received: from mga11.intel.com ([192.55.52.93]:24220 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755475AbbLQJfW convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 04:35:22 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,440,1444719600"; d="scan'208";a="619463538" From: "Du, Changbin" To: Felipe Balbi CC: "gregkh@linuxfoundation.org" , "John.Youn@synopsys.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lkp@01.org" , "Wu, Fengguang" Subject: RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep Thread-Topic: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep Thread-Index: AQHRNiOBB4GUT2RkY0urSX+e3x3Jgp7KRD9ggAMNkwCAAZ1/cA== Date: Thu, 17 Dec 2015 09:35:18 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01DF8A53@SHSMSX103.ccr.corp.intel.com> References: <87twnqi567.fsf@saruman.tx.rr.com> <1450064926-849-1-git-send-email-changbin.du@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A01DF62CC@SHSMSX103.ccr.corp.intel.com> <87h9jifi9x.fsf@saruman.tx.rr.com> In-Reply-To: <87h9jifi9x.fsf@saruman.tx.rr.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 20 > >> 2.5.0 > > > > With this patch, ep0 transfer breaks. it because the 'enabled' of ep0 > > is not set. Ep0 is not enabled by usb_ep_enable, but in UDC driver. So > > there need another patch to set ep0's flag also. > > yeah, we don't like regressions :-) So the fix should come before > $subject to avoid a regression. > > -- > balbi It is hard to determine if ep0 is enabled or not in gadget API layer. Because it is controlled by udc driver, it may enable it at pullup, vbussession... But here, we can ignore for control-ep, considering it always enabled during usb session. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/