Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934576AbbLQLEp (ORCPT ); Thu, 17 Dec 2015 06:04:45 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33704 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932323AbbLQLEo (ORCPT ); Thu, 17 Dec 2015 06:04:44 -0500 Date: Thu, 17 Dec 2015 14:04:35 +0300 From: Dan Carpenter To: Okash Khawaja Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: fix large frame size compiler warning Message-ID: <20151217110435.GG5284@mwanda> References: <20151216205545.GA12609@bytefire-computer> <20151216211534.GA13478@bytefire-computer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151216211534.GA13478@bytefire-computer> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1747 Lines: 44 Put a v3 in the subject. There are still paths where this is not freed, so we need a v4. Take your time, there is no rush. > drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > index 130c852..77eed52 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c > @@ -594,12 +594,22 @@ static void RxReorderIndicatePacket(struct ieee80211_device *ieee, > { > PRT_HIGH_THROUGHPUT pHTInfo = ieee->pHTInfo; > PRX_REORDER_ENTRY pReorderEntry = NULL; > - struct ieee80211_rxb *prxbIndicateArray[REORDER_WIN_SIZE]; > + struct ieee80211_rxb **prxbIndicateArray; > u8 WinSize = pHTInfo->RxReorderWinSize; > u16 WinEnd = (pTS->RxIndicateSeq + WinSize -1)%4096; > u8 index = 0; > bool bMatchWinStart = false, bPktInBuf = false; > IEEE80211_DEBUG(IEEE80211_DL_REORDER,"%s(): Seq is %d,pTS->RxIndicateSeq is %d, WinSize is %d\n",__func__,SeqNum,pTS->RxIndicateSeq,WinSize); > + > + prxbIndicateArray = kmalloc(sizeof(struct ieee80211_rxb *) * > + REORDER_WIN_SIZE, GFP_KERNEL); > + if (!prxbIndicateArray) { > + IEEE80211_DEBUG(IEEE80211_DL_ERR, > + "%s(): kmalloc prxbIndicateArray error\n", > + __func__); Don't print an error if kmalloc() fails. kmalloc has its own message. > + return; > + } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/