MIME-Version: 1.0
In-Reply-To: <20151216103927.GS19456@lukather>
References: <1450080676-6704-1-git-send-email-mweseloh42@gmail.com>
	<20151216103927.GS19456@lukather>
Date: Thu, 17 Dec 2015 12:22:49 +0100
Message-ID: <CAGNoLaN=HJ-OR6oFiGWC58DG+w1A9qeEVyGBRb1vdf9BRNW=Rg@mail.gmail.com>
Subject: Re: [PATCH v4] spi: dts: sun4i: Add support for wait time between
 word transmissions
From: Marcus Weseloh <mweseloh42@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-sunxi <linux-sunxi@googlegroups.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>, devicetree <devicetree@vger.kernel.org>,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        "Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1233
Lines: 36

Hi Maxime,

2015-12-16 11:39 GMT+01:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> It looks mostly fine, however, please try to make only one thing in
> one patch.
>
> In this case, it would mean having one patch to add the DT property
> and support in the SPI core in a first one, and then add support for
> it in your driver.

Will do.

> I also have a minor comment below....
[...]
>> +     if (spi->word_wait_ns) {
>> +             clk_ns = DIV_ROUND_UP(1000000000, tfr->speed_hz);
>> +             wait_clk = DIV_ROUND_UP(spi->word_wait_ns, clk_ns) - 3;
>> +             if (wait_clk < 1) {
>> +                     wait_clk = 1;
>> +                     dev_info(&spi->dev,
>> +                              "using minimum of 4 word wait cycles (%uns)",
>> +                              4 * clk_ns);
>
> Logging it at the info loglevel seems a bit too high. debug seems more
> appropriate.

I will change it to debug and send a new version.

Thanks for the review!

Marcus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/