Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756617AbbLQLcc (ORCPT ); Thu, 17 Dec 2015 06:32:32 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:40474 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756572AbbLQLc3 (ORCPT ); Thu, 17 Dec 2015 06:32:29 -0500 X-IronPort-AV: E=Sophos;i="5.20,440,1444662000"; d="scan'208";a="202015459" From: Phil Edworthy To: Paul Gortmaker CC: "linux-kernel@vger.kernel.org" , "Simon Horman" , Bjorn Helgaas , linux-pci , Linux-sh list , "Geert Uytterhoeven" Subject: RE: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Thread-Topic: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Thread-Index: AQHRNUfFl+ndidkJYEO7bCtOPoWf657Iv9kAgAZLZ/A= Date: Thu, 17 Dec 2015 11:32:23 +0000 Message-ID: References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=phil.edworthy@renesas.com; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;PS1PR06MB1179;5:4M+JzP/D1t/dlSZvInWeSzTt7kPLaFTSb3tWdFIODJNwYlFniaemx5lnfIWMQjukPu3bLHQRvwjxpwnZXbd3BKgBJomPNnedSJprMHryO4/1STVe4OyqQRig6djd/uVVbd6WxUkMeTGeaGYnhRfkow==;24:2piPTa3F8igY7kq61BryhFn20U5SXrH14TtUaMbhGw2IVx5+UhA5Wl9OqJgSIorZvbD9cWRIfBbJ1htBo3iHTBiOvE2U0aB2rLr8n5ZeSQk=;20:HsZbtYgJThY3ymRzDlUWz4HBKMVIXSEQXNVvdSaFab505CqMZqWsqmf7jWOtd0XTPFzaCsdtt9z6/qYwoC44gLPNtzLu1qXW+aB8voSZMIfgP3bphfHumPgpkTkq8uuhElKlXbZNcqLtsd+rVHBgiKaRk+Nr1RlsIdnPtRu01FM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1179; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85106069007906); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:PS1PR06MB1179;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1179; x-forefront-prvs: 07935ACF08 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(377454003)(24454002)(106356001)(1220700001)(2950100001)(1096002)(5002640100001)(2900100001)(92566002)(106116001)(105586002)(54356999)(122556002)(74316001)(40100003)(66066001)(5003600100002)(6116002)(102836003)(15975445007)(3846002)(76176999)(77096005)(586003)(10400500002)(5001960100002)(5004730100002)(110136002)(97736004)(81156007)(189998001)(19580405001)(76576001)(19580395003)(86362001)(87936001)(5008740100001)(33656002)(101416001)(11100500001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1179;H:PS1PR06MB1180.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2015 11:32:23.3132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1179 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBHBWZHU015678 Content-Length: 3733 Lines: 101 Hi Paul, On 13 December 2015 10:59, Geert Uytterhoeven wrote: > > CC MODULE_AUTHOR > > On Sun, Dec 13, 2015 at 2:41 AM, Paul Gortmaker > wrote: > > The Kconfig currently controlling compilation of this code is: > > > > drivers/pci/host/Kconfig:config PCI_RCAR_GEN2_PCIE > > drivers/pci/host/Kconfig: bool "Renesas R-Car PCIe controller" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > > > Since module_platform_driver() uses the same init level priority as > > builtin_platform_driver() the init ordering remains unchanged with > > this commit. > > > > We don't have to disallow a driver unbind, since that is already > > done for us in this driver. > > > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > > > We also delete the MODULE_LICENSE tag etc. since all that information > > was (or is now) contained at the top of the file in the comments. > > > > Cc: Simon Horman > > Cc: Bjorn Helgaas > > Cc: linux-pci@vger.kernel.org > > Cc: linux-sh@vger.kernel.org > > Signed-off-by: Paul Gortmaker It doesn't apply, would you mind rebasing onto: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=next As for the changes themselves, Acked-by: Phil Edworthy Thanks Phil > > --- > > drivers/pci/host/pcie-rcar.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > > index f4fa6c537448..2c619277d265 100644 > > --- a/drivers/pci/host/pcie-rcar.c > > +++ b/drivers/pci/host/pcie-rcar.c > > @@ -7,6 +7,8 @@ > > * arch/sh/drivers/pci/ops-sh7786.c > > * Copyright (C) 2009 - 2011 Paul Mundt > > * > > + * Module Author: Phil Edworthy > > + * > > * This file is licensed under the terms of the GNU General Public > > * License version 2. This program is licensed "as is" without any > > * warranty of any kind, whether express or implied. > > @@ -18,7 +20,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > #include > > #include > > @@ -921,7 +923,6 @@ static const struct of_device_id rcar_pcie_of_match[] = { > > { .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init }, > > {}, > > }; > > -MODULE_DEVICE_TABLE(of, rcar_pcie_of_match); > > > > static int rcar_pcie_probe(struct platform_device *pdev) > > { > > @@ -1007,8 +1008,4 @@ static struct platform_driver rcar_pcie_driver = { > > }, > > .probe = rcar_pcie_probe, > > }; > > -module_platform_driver(rcar_pcie_driver); > > - > > -MODULE_AUTHOR("Phil Edworthy "); > > -MODULE_DESCRIPTION("Renesas R-Car PCIe driver"); > > -MODULE_LICENSE("GPL v2"); > > +builtin_platform_driver(rcar_pcie_driver); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?