Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966384AbbLQLmC (ORCPT ); Thu, 17 Dec 2015 06:42:02 -0500 Received: from foss.arm.com ([217.140.101.70]:60980 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964798AbbLQLl7 (ORCPT ); Thu, 17 Dec 2015 06:41:59 -0500 Date: Thu, 17 Dec 2015 11:41:53 +0000 From: Catalin Marinas To: Yury Norov Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, Andrew Pinski , jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 08/20] arm64: ilp32: add is_ilp32_compat_{task, thread} and TIF_32BIT_AARCH64 Message-ID: <20151217114153.GD25232@e104818-lin.cambridge.arm.com> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-9-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450215766-14765-9-git-send-email-ynorov@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 41 On Wed, Dec 16, 2015 at 12:42:34AM +0300, Yury Norov wrote: > Reviewed-by: David Daney > Signed-off-by: Philipp Tomsich > Signed-off-by: Christoph Muellner > Signed-off-by: Yury Norov > Signed-off-by: Andrew Pinski Long description missing. > diff --git a/arch/arm64/include/asm/is_compat.h b/arch/arm64/include/asm/is_compat.h > index 476db90..89b1f65 100644 > --- a/arch/arm64/include/asm/is_compat.h > +++ b/arch/arm64/include/asm/is_compat.h > @@ -36,7 +36,6 @@ static inline int is_a32_compat_thread(struct thread_info *thread) > #else > > static inline int is_a32_compat_task(void) > - > { > return 0; > } You should move this to the previous patch. > @@ -45,14 +44,39 @@ static inline int is_a32_compat_thread(struct thread_info *thread) > { > return 0; > } > - > #endif /* CONFIG_AARCH32_EL0 */ Maybe this one as well, though I like an empty line before the last #endif (i.e. drop this hunk). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/