Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965854AbbLQMwW (ORCPT ); Thu, 17 Dec 2015 07:52:22 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34793 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751672AbbLQMwV convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 07:52:21 -0500 From: Gregory CLEMENT To: Sudip Mukherjee Cc: Nicolas Ferre , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH] net/macb: add proper header file References: <1450354553-18745-1-git-send-email-sudipm.mukherjee@gmail.com> Date: Thu, 17 Dec 2015 13:41:59 +0100 In-Reply-To: <1450354553-18745-1-git-send-email-sudipm.mukherjee@gmail.com> (Sudip Mukherjee's message of "Thu, 17 Dec 2015 17:45:53 +0530") Message-ID: <87twnhs0vc.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2630 Lines: 72 Hi Sudip, On jeu., déc. 17 2015, Sudip Mukherjee wrote: > mips allmodconfig build fails with the error: > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] > bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) > GPIOD_OUT_HIGH); > ^ > drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in > drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': > drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > gpiod_set_value(bp->reset_gpio, 0); > ^ > > Add the proper header file to resolve it. A proper fix already has been posted along with the proper device tree bindinsg too: http://marc.info/?l=linux-netdev&m=145034590619620&w=2 Thanks, Gregory > > Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") > Cc: Gregory CLEMENT > Signed-off-by: Sudip Mukherjee > --- > > build log with next-20151217 is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 > > drivers/net/ethernet/cadence/macb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 0123646..988ee14 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/