From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>
CC: Support Opensource <Support.Opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mfd: da9063: Allow modular build
Thread-Topic: [PATCH] mfd: da9063: Allow modular build
Thread-Index: AQHRMQqrqhiWLhimtkKIV0UQQMsUFZ7BHkmAgA4UNvA=
Date: Thu, 17 Dec 2015 13:26:19 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173D28E2E@SW-EX-MBX02.diasemi.com>
References: <1449505003-5243-1-git-send-email-geert+renesas@glider.be>
 <20151208135607.GI3384@x1>
In-Reply-To: <20151208135607.GI3384@x1>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1704
Lines: 52

On 08 December 2015 13:56, Lee Jones wrote:

> To: Geert Uytterhoeven
> Subject: Re: [PATCH] mfd: da9063: Allow modular build
> 
> On Mon, 07 Dec 2015, Geert Uytterhoeven wrote:
> 
> > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which
> > allows to decrease size of multi-platform kernels (e.g.
> > multi_v7_defconfig).
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> The DA9063 driver appears to contain all module code.  In fact, I'm
> surprised that it wasn't enabled for tristate in the first place.
> 
> In any case, it would be good to get a Reviewed/Acked-by from one of
> the Dialog guys.

Yes. 
Without this we cannot load any of the sub-devices as modules for the DA9063.
Sorry this has taken so long for me to look at.

Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve

> 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 4d92df6ef9fe92ac..527ee7168617c933 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -211,7 +211,7 @@ config MFD_DA9062
> >  	  of the device.
> >
> >  config MFD_DA9063
> > -	bool "Dialog Semiconductor DA9063 PMIC Support"
> > +	tristate "Dialog Semiconductor DA9063 PMIC Support"
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> >  	select REGMAP_IRQ
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?