Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966425AbbLQNlU (ORCPT ); Thu, 17 Dec 2015 08:41:20 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:34440 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964888AbbLQNlR (ORCPT ); Thu, 17 Dec 2015 08:41:17 -0500 MIME-Version: 1.0 In-Reply-To: <20151217133058.GA20372@katana> References: <1450358557-28376-1-git-send-email-phil.edworthy@renesas.com> <1450358557-28376-3-git-send-email-phil.edworthy@renesas.com> <20151217133058.GA20372@katana> Date: Thu, 17 Dec 2015 14:41:16 +0100 X-Google-Sender-Auth: yN6iVSpG2OdGdjlYCTUYxfU8fa4 Message-ID: Subject: Re: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar From: Geert Uytterhoeven To: Wolfram Sang Cc: Phil Edworthy , Simon Horman , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , linux-pci , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 24 On Thu, Dec 17, 2015 at 2:30 PM, Wolfram Sang wrote: >> + /* Wait until we are in L1 */ >> + while (!(val & L1FAEG)) >> + val = rcar_pci_read_reg(pcie, PMSR); > > No timeout? And no cpu_relax() in each iteration. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/