Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S967025AbbLQPTG (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Dec 2015 10:19:06 -0500
Received: from mga02.intel.com ([134.134.136.20]:30249 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932318AbbLQPTD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Dec 2015 10:19:03 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,441,1444719600"; 
   d="scan'208";a="873562381"
Message-ID: <1450365401.30729.142.camel@linux.intel.com>
Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        "James E.J. Bottomley" <jejb@parisc-linux.org>,
        Helge Deller <deller@gmx.de>, Peter Hurley <peter@hurleysoftware.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Qipeng Zha <qipeng.zha@intel.com>, Desmond Liu <desmondl@broadcom.com>,
        Wang Long <long.wanglong@huawei.com>,
        Matt Redfearn <matt.redfearn@imgtec.com>,
        Paul Burton <paul.burton@imgtec.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Peter Hung <hpeter@gmail.com>,
        Soeren Grunewald <soeren.grunewald@desy.de>,
        Adam Lee <adam.lee@canonical.com>,
        "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Mans Rullgard <mans@mansr.com>, linux-kernel@vger.kernel.org,
        linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de,
        Phillip Raffeck <phillip.raffeck@fau.de>
Date: Thu, 17 Dec 2015 17:16:41 +0200
In-Reply-To: <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de>
References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de>
	 <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.2-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1546
Lines: 45

On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote:
> This patch fixes a checkpatch warning caused by missing parentheses
> in the definition of a macro.
> 
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c
> b/drivers/tty/serial/8250/8250_core.c
> index 67147b2..3c29530 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void)
>  }
>  console_initcall(univ8250_console_init);
>  
> -#define SERIAL8250_CONSOLE	&univ8250_console
> +#define SERIAL8250_CONSOLE	(&univ8250_console)

What about the rest of the drivers under drivers/tty/serial?

What do you propose to do with, for example, the following

drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
CPM_UART_CONSOLE       &cpm_scc_uart_console
drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
CPM_UART_CONSOLE       NULL

>  #else
>  #define SERIAL8250_CONSOLE	NULL
>  #endif

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/