Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967106AbbLQPdH (ORCPT ); Thu, 17 Dec 2015 10:33:07 -0500 Received: from m12-17.163.com ([220.181.12.17]:56150 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966279AbbLQPdG (ORCPT ); Thu, 17 Dec 2015 10:33:06 -0500 Date: Thu, 17 Dec 2015 23:24:53 +0800 From: Tao Zhou To: walken@google.com Cc: linux-kernel@vger.kernel.org, t1zhou@163.com Subject: [PATCH] rbtree: correct comments about rotation operation Message-ID: <20151217152453.GA3147@root> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-CM-TRANSID: EcCowABXfVKV1XJWhN3CAg--.30608S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFyxCw18tw4kXr45GF15Jwb_yoWfKrg_C3 9Iyr4kWay5Zan7Jry3uw4qqFZ5CrW3CFs2kr1YkrZ7Ca40yrW3uFyDZr4qvw15Wr1xuFy3 Grs8Xry2yw4xKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUSAp7UUUUU== X-Originating-IP: [221.194.160.84] X-CM-SenderInfo: vwr2x0rx6rljoofrz/xtbBdhXTllUL5v0tVQAAsb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 39 The rotation operation is symmetric. So the comments about rotation operation need to be corrected. Signed-off-by: Tao Zhou --- lib/rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rbtree.c b/lib/rbtree.c index 1356454..750cfa8 100644 --- a/lib/rbtree.c +++ b/lib/rbtree.c @@ -365,7 +365,7 @@ ____rb_erase_color(struct rb_node *parent, struct rb_root *root, } break; } - /* Case 3 - right rotate at sibling */ + /* Case 3 - left rotate at sibling */ tmp1 = tmp2->rb_left; WRITE_ONCE(sibling->rb_right, tmp1); WRITE_ONCE(tmp2->rb_left, sibling); @@ -377,7 +377,7 @@ ____rb_erase_color(struct rb_node *parent, struct rb_root *root, tmp1 = sibling; sibling = tmp2; } - /* Case 4 - left rotate at parent + color flips */ + /* Case 4 - right rotate at parent + color flips */ tmp2 = sibling->rb_right; WRITE_ONCE(parent->rb_left, tmp2); WRITE_ONCE(sibling->rb_right, parent); -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/