Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967035AbbLQPnX (ORCPT ); Thu, 17 Dec 2015 10:43:23 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:50447 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964835AbbLQPnS (ORCPT ); Thu, 17 Dec 2015 10:43:18 -0500 Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c To: Paul Gortmaker , , , "Greg Kroah-Hartman" References: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> CC: Jiri Slaby , Sudip Mukherjee From: Nicolas Ferre Organization: atmel Message-ID: <5672D82A.1090401@atmel.com> Date: Thu, 17 Dec 2015 16:43:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 59 Le 17/12/2015 16:05, Paul Gortmaker a ?crit : > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial: > make serial/atmel_serial.c explicitly non-modular") we removed the code > relating to modular support since it currently only supports built in. > > However, when redoing my build coverage for mips allmodconfig, which > sets CONFIG_OF, I noticed a remaining line that needs to be removed, > else we will get a build failure for an undefined module macro. > > Unfortunately this didn't appear for any of the other arch I tested > more frequently, such as ARM. > > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just > remove the offending line. > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > Cc: Nicolas Ferre Absolutely: Acked-by: Nicolas Ferre Thank you Sudip and Paul. Bye, > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Sudip Mukherjee > Reported-by: Sudip Mukherjee > Signed-off-by: Paul Gortmaker > --- > drivers/tty/serial/atmel_serial.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 50e785a0ea73..1c0884d8ef32 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = { > { .compatible = "atmel,at91sam9260-usart" }, > { /* sentinel */ } > }; > - > -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids); > #endif > > static inline struct atmel_uart_port * > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/