Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935005AbbLQQC5 (ORCPT ); Thu, 17 Dec 2015 11:02:57 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:46003 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934785AbbLQQCx convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 11:02:53 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: Greg Kroah-Hartman , Magnus Damm , linux-serial@vger.kernel.org, LKML , Mason Subject: Re: [PATCH] use callbacks to access UART_DLL/UART_DLM References: <5672D89A.4090307@laposte.net> Date: Thu, 17 Dec 2015 16:02:52 +0000 In-Reply-To: <5672D89A.4090307@laposte.net> (Sebastian Frias's message of "Thu, 17 Dec 2015 16:45:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1999 Lines: 62 Sebastian Frias writes: > --- > resending as plain-text > --- > drivers/tty/serial/8250/8250_core.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 2c46a21..9ca863c 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -791,22 +791,19 @@ static int size_fifo(struct uart_8250_port *up) > */ > static unsigned int autoconfig_read_divisor_id(struct uart_8250_port *p) What tree are you working against? Current mainline has that function in 8250_port.c. > { > - unsigned char old_dll, old_dlm, old_lcr; > + unsigned char old_lcr; > unsigned int id; > + unsigned int old_dl; Your patch is messed up. Consider using "git send-email" instead. > old_lcr = serial_in(p, UART_LCR); > - serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); > - > - old_dll = serial_in(p, UART_DLL); > - old_dlm = serial_in(p, UART_DLM); > > - serial_out(p, UART_DLL, 0); > - serial_out(p, UART_DLM, 0); > + serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); > > - id = serial_in(p, UART_DLL) | serial_in(p, UART_DLM) << 8; > + old_dl = serial_dl_read(p); > + serial_dl_write(p, 0); > + id = serial_dl_read(p); > + serial_dl_write(p, old_dl); > > - serial_out(p, UART_DLL, old_dll); > - serial_out(p, UART_DLM, old_dlm); > serial_out(p, UART_LCR, old_lcr); > > return id; > -- If you left the blank lines alone, the patch would end up much easier to understand. In this diff, some of the lines listed as added or removed have actually not changed, and that's not immediately obvious. -- M?ns Rullg?rd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/