Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966197AbbLQQ2W (ORCPT ); Thu, 17 Dec 2015 11:28:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:53446 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756884AbbLQQ2T (ORCPT ); Thu, 17 Dec 2015 11:28:19 -0500 Date: Thu, 17 Dec 2015 17:28:17 +0100 From: Petr Mladek To: Josh Poimboeuf Cc: Jessica Yu , Rusty Russell , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Jonathan Corbet , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2 2/6] module: preserve Elf information for livepatch modules Message-ID: <20151217162817.GI3729@pathway.suse.cz> References: <1448943679-3412-1-git-send-email-jeyu@redhat.com> <1448943679-3412-3-git-send-email-jeyu@redhat.com> <20151208183212.GB14846@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151208183212.GB14846@treble.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2364 Lines: 62 On Tue 2015-12-08 12:32:12, Josh Poimboeuf wrote: > On Mon, Nov 30, 2015 at 11:21:15PM -0500, Jessica Yu wrote: > > For livepatch modules, copy Elf section, symbol, and string information > > from the load_info struct in the module loader. > > > > Livepatch uses special relocation sections in order to be able to patch > > modules that are not yet loaded, as well as apply patches to the kernel > > when the addresses of symbols cannot be determined at compile time (for > > example, when kaslr is enabled). Livepatch modules must preserve Elf > > information such as section indices in order to apply the remaining > > relocation sections at the appropriate time (i.e. when the target module > > loads). > > > > Signed-off-by: Jessica Yu > > --- > > include/linux/module.h | 9 +++++ > > kernel/module.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++-- > > 2 files changed, 105 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/module.h b/include/linux/module.h > > index 3a19c79..9b46256 100644 > > --- a/include/linux/module.h > > +++ b/include/linux/module.h > > @@ -425,6 +425,14 @@ struct module { > > > > /* Notes attributes */ > > struct module_notes_attrs *notes_attrs; > > + > > + /* Elf information (optionally saved) */ > > + Elf_Ehdr *hdr; > > I would rename "hdr" to "elf_hdr" to make its purpose clearer. > > > + Elf_Shdr *sechdrs; > > + char *secstrings; > > Probably a good idea to add underscores to the names ("sec_hdrs" and > "sec_strings") to be consistent with most of the other fields in the > struct. We should keep the names in sync with struct load_info. > > + struct { > > + unsigned int sym, str, mod, vers, info, pcpu; > > + } index; > > I might be contradicting myself from what I said before. But I'm > thinking we should put all these fields inside a CONFIG_LIVEPATCH ifdef. > Then below, there could be two versions of copy_module_elf(), the real > one for LIVEPATCH and and an empty one for !LIVEPATCH. And the same > story for free_module_elf(). Yes, I would hide these fields for !LIVEPATCH. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/