Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967180AbbLQQbN (ORCPT ); Thu, 17 Dec 2015 11:31:13 -0500 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:40569 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964955AbbLQQbL convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 11:31:11 -0500 Date: Fri, 18 Dec 2015 01:31:08 +0900 Message-ID: <87bn9pnik3.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Guenter Roeck Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , uclinux-h8-devel@lists.sourceforge.jp, linux-kernel@vger.kernel.org, Daniel Lezcano Subject: Re: [PATCH -next] irqchip: renesas-h8s: Replace ctrl_outw/ctrl_inw with writew/readw In-Reply-To: <1450240237-17187-1-git-send-email-linux@roeck-us.net> References: <1450240237-17187-1-git-send-email-linux@roeck-us.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2389 Lines: 72 On Wed, 16 Dec 2015 13:30:37 +0900, Guenter Roeck wrote: > > Commit 13ae42a3b1c1 ("h8300: Rename ctlr_out/in[bwl] to > raw_read/write[bwl]") changed the function names, but not all callers, > resulting in > > drivers/irqchip/irq-renesas-h8s.c: In function ?h8s_disable_irq?: > drivers/irqchip/irq-renesas-h8s.c:43:9: error: > implicit declaration of function ?ctrl_inw? > drivers/irqchip/irq-renesas-h8s.c:44:2: error: > implicit declaration of function ?ctrl_outw? > > Fixes: 13ae42a3b1c1 ("h8300: Rename ctlr_out/in[bwl] to raw_read/write[bwl]") > Cc: Daniel Lezcano > Signed-off-by: Guenter Roeck Applied. Thanks. > --- > drivers/irqchip/irq-renesas-h8s.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/irqchip/irq-renesas-h8s.c b/drivers/irqchip/irq-renesas-h8s.c > index 8098ead1eb22..af8c6c61c824 100644 > --- a/drivers/irqchip/irq-renesas-h8s.c > +++ b/drivers/irqchip/irq-renesas-h8s.c > @@ -40,8 +40,8 @@ static void h8s_disable_irq(struct irq_data *data) > addr = IPRA + ((ipr_table[irq - 16] & 0xf0) >> 3); > pos = (ipr_table[irq - 16] & 0x0f) * 4; > pri = ~(0x000f << pos); > - pri &= ctrl_inw(addr); > - ctrl_outw(pri, addr); > + pri &= readw(addr); > + writew(pri, addr); > } > > static void h8s_enable_irq(struct irq_data *data) > @@ -54,9 +54,9 @@ static void h8s_enable_irq(struct irq_data *data) > addr = IPRA + ((ipr_table[irq - 16] & 0xf0) >> 3); > pos = (ipr_table[irq - 16] & 0x0f) * 4; > pri = ~(0x000f << pos); > - pri &= ctrl_inw(addr); > + pri &= readw(addr); > pri |= 1 << pos; > - ctrl_outw(pri, addr); > + writew(pri, addr); > } > > struct irq_chip h8s_irq_chip = { > @@ -90,7 +90,7 @@ static int __init h8s_intc_of_init(struct device_node *intc, > /* All interrupt priority is 0 (disable) */ > /* IPRA to IPRK */ > for (n = 0; n <= 'k' - 'a'; n++) > - ctrl_outw(0x0000, IPRA + (n * 2)); > + writew(0x0000, IPRA + (n * 2)); > > domain = irq_domain_add_linear(intc, NR_IRQS, &irq_ops, NULL); > BUG_ON(!domain); > -- > 2.1.4 > -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/