Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967216AbbLQQsM (ORCPT ); Thu, 17 Dec 2015 11:48:12 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:36223 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932470AbbLQQsK (ORCPT ); Thu, 17 Dec 2015 11:48:10 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 17 Dec 2015 08:48:09 -0800 Message-ID: Subject: Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" From: Dan Williams To: Russell King Cc: tomeu.vizoso@collabora.com, m.szyprowski@samsung.com, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , Stephen Rothwell Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 35 On Thu, Dec 17, 2015 at 7:51 AM, Dan Williams wrote: > The commit below causes the libnvdimm sub-system to stop loading. > This is due to the fact that nvdimm_bus_match() returns the result of > test_bit() which may be negative. If there are any other bus match > functions using test_bit they may be similarly impacted. > > Can we queue a fixup like the following to libnvdimm, and maybe > others, ahead of this driver core change? > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > index 7e2c43f701bc..2b2181cdeb63 100644 > --- a/drivers/nvdimm/bus.c > +++ b/drivers/nvdimm/bus.c > @@ -62,7 +62,7 @@ static int nvdimm_bus_match(struct device *dev, > struct device_driver *drv) > { > struct nd_device_driver *nd_drv = to_nd_device_driver(drv); > > - return test_bit(to_nd_device_type(dev), &nd_drv->type); > + return !!test_bit(to_nd_device_type(dev), &nd_drv->type); > } > > static struct module *to_bus_provider(struct device *dev) > > > > > Other ideas? How about just checking for EPROBE_DEFER, every other non-zero value is success. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/