Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456AbbLQSJK (ORCPT ); Thu, 17 Dec 2015 13:09:10 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:46400 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbLQSJJ convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 13:09:09 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: Greg Kroah-Hartman , Magnus Damm , linux-serial@vger.kernel.org, LKML , Mason Subject: Re: [PATCH] use callbacks to access UART_DLL/UART_DLM References: <5672D89A.4090307@laposte.net> <5672F9C9.1010601@laposte.net> Date: Thu, 17 Dec 2015 18:09:07 +0000 In-Reply-To: <5672F9C9.1010601@laposte.net> (Sebastian Frias's message of "Thu, 17 Dec 2015 19:07:05 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 44 Sebastian Frias writes: >>> old_lcr = serial_in(p, UART_LCR); >>> - serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); >>> - >>> - old_dll = serial_in(p, UART_DLL); >>> - old_dlm = serial_in(p, UART_DLM); >>> >>> - serial_out(p, UART_DLL, 0); >>> - serial_out(p, UART_DLM, 0); >>> + serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); >>> >>> - id = serial_in(p, UART_DLL) | serial_in(p, UART_DLM) << 8; >>> + old_dl = serial_dl_read(p); >>> + serial_dl_write(p, 0); >>> + id = serial_dl_read(p); >>> + serial_dl_write(p, old_dl); >>> >>> - serial_out(p, UART_DLL, old_dll); >>> - serial_out(p, UART_DLM, old_dlm); >>> serial_out(p, UART_LCR, old_lcr); >>> >>> return id; >>> -- >> >> If you left the blank lines alone, the patch would end up much easier to >> understand. In this diff, some of the lines listed as added or removed >> have actually not changed, and that's not immediately obvious. >> > > The old code had some blank lines, which I suppose were there for clarity. > I attempted to follow the same idea. > But I don't mind changing the code as you wish. It could well be that your patch results in a clearer final version, but the diff is harder to parse when unchanged lines have moved around. -- M?ns Rullg?rd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/