Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbbLQSQF (ORCPT ); Thu, 17 Dec 2015 13:16:05 -0500 Received: from mga03.intel.com ([134.134.136.65]:64134 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbbLQSQD (ORCPT ); Thu, 17 Dec 2015 13:16:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,442,1444719600"; d="scan'208";a="843437015" Date: Thu, 17 Dec 2015 18:16:00 +0000 From: Keith Busch To: Bjorn Helgaas Cc: LKML , x86@kernel.org, linux-pci@vger.kernel.org, Jiang Liu , Thomas Gleixner , Dan Williams , Bjorn Helgaas , Bryan Veal , Ingo Molnar , "H. Peter Anvin" , Martin Mares , Jon Derrick Subject: Re: [PATCHv6 6/7] aer_inject: Use 32 bit int type domains Message-ID: <20151217181600.GC31031@localhost.localdomain> References: <1449523949-21898-1-git-send-email-keith.busch@intel.com> <1449523949-21898-7-git-send-email-keith.busch@intel.com> <20151217174615.GE23549@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151217174615.GE23549@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 17 On Thu, Dec 17, 2015 at 11:46:15AM -0600, Bjorn Helgaas wrote: > On Mon, Dec 07, 2015 at 02:32:28PM -0700, Keith Busch wrote: > > - u16 domain; > > + int domain; > > If you want 32 bits explicitly, why don't you use u32 here? It matches the types already defined in struct pci_dev and the pci_domain_nr return value. Would you prefer changing all of them to u32, just aer_inject's, or leave as-is? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/