Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753867AbbLQS5O (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Dec 2015 13:57:14 -0500
Received: from mail.kernel.org ([198.145.29.136]:40053 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751382AbbLQS5M (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Dec 2015 13:57:12 -0500
Date: Thu, 17 Dec 2015 15:57:07 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCH 17/25] perf stat report: Move csv_sep initialization
 before report command
Message-ID: <20151217185707.GM19926@kernel.org>
References: <1446734469-11352-1-git-send-email-jolsa@kernel.org>
 <1446734469-11352-18-git-send-email-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1446734469-11352-18-git-send-email-jolsa@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 4216
Lines: 99

Em Thu, Nov 05, 2015 at 03:41:01PM +0100, Jiri Olsa escreveu:
> So we have csv_sep properly initialized before
> report command leg.

I moved this to before "perf stat report: Process stat and stat round
events" so that what you wrote above makes sense, i.e. after this patch
nothing is produced by 'perf stat report' and right after the stat and
stat round one is applied I get:

  [acme@ssdandy linux]$ perf stat report

   Performance counter stats for '/home/acme/bin/perf stat record usleep 1':

          0.411636      task-clock (msec)         #    0.571 CPUs utilized          
                 2      context-switches          #    0.005 M/sec                  
                 0      cpu-migrations            #    0.000 K/sec                  
               149      page-faults               #    0.362 M/sec                  
         1,291,807      cycles                    #    3.138 GHz                    
           959,632      stalled-cycles-frontend   #   74.29% frontend cycles idle   
           703,170      stalled-cycles-backend    #   54.43% backend  cycles idle   
           757,538      instructions              #    0.59  insns per cycle        
                                                  #    1.27  stalled cycles per insn
           133,293      branches                  #  323.813 M/sec                  
     <not counted>      branch-misses              (0.00%)

       0.000720394 seconds time elapsed

  [acme@ssdandy linux]$ 

And not this ugly thing:

  [acme@ssdandy linux]$ perf stat report

   Performance counter stats for '/home/acme/bin/perf stat record usleep 1':

          0.411636(null)    (null)task-clock (msec)         #    0.571 CPUs utilized          
                 2(null)    (null)context-switches          #    0.005 M/sec                  
                 0(null)    (null)cpu-migrations            #    0.000 K/sec                  
               149(null)    (null)page-faults               #    0.362 M/sec                  
         1,291,807(null)    (null)cycles                    #    3.138 GHz                    
           959,632(null)    (null)stalled-cycles-frontend   #   74.29% frontend cycles idle   
           703,170(null)    (null)stalled-cycles-backend    #   54.43% backend  cycles idle   
           757,538(null)    (null)instructions              #    0.59  insns per cycle        
                                                  #    1.27  stalled cycles per insn
           133,293(null)    (null)branches                  #  323.813 M/sec                  
     <not counted>(null)    (null)branch-misses              (0.00%)

       0.000720394 seconds time elapsed

  [acme@ssdandy linux]$

- Arnaldo
 
> Tested-by: Kan Liang <kan.liang@intel.com>
> Link: http://lkml.kernel.org/n/tip-i5mmbomj7lt4eg04awzocdd4@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/builtin-stat.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 6636d29b3b18..174ffbd02a13 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1776,6 +1776,13 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
>  					(const char **) stat_usage,
>  					PARSE_OPT_STOP_AT_NON_OPTION);
>  
> +	if (csv_sep) {
> +		csv_output = true;
> +		if (!strcmp(csv_sep, "\\t"))
> +			csv_sep = "\t";
> +	} else
> +		csv_sep = DEFAULT_SEPARATOR;
> +
>  	if (argc && !strncmp(argv[0], "rec", 3)) {
>  		argc = __cmd_record(argc, argv);
>  		if (argc < 0)
> @@ -1826,13 +1833,6 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
>  
>  	stat_config.output = output;
>  
> -	if (csv_sep) {
> -		csv_output = true;
> -		if (!strcmp(csv_sep, "\\t"))
> -			csv_sep = "\t";
> -	} else
> -		csv_sep = DEFAULT_SEPARATOR;
> -
>  	/*
>  	 * let the spreadsheet do the pretty-printing
>  	 */
> -- 
> 2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/