Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807AbbLQTZo (ORCPT ); Thu, 17 Dec 2015 14:25:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:37761 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbbLQTZm (ORCPT ); Thu, 17 Dec 2015 14:25:42 -0500 Subject: Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management To: "Martin K. Petersen" , Hannes Reinecke References: <1444830904.2220.28.camel@HansenPartnership.com> <561EA018.7020700@suse.com> <1444848835.2220.50.camel@HansenPartnership.com> <5644BEE1.3010208@suse.com> <5649C79E.9070603@suse.de> <564A4EDC.8060805@suse.com> <5669F31C.2010409@suse.com> <1449847911.4067.200.camel@localhost.localdomain> <566DC3F0.6050206@suse.com> <1450105632.4091.17.camel@localhost.localdomain> <566EE055.9050708@suse.de> Cc: emilne@redhat.com, James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Hannes Reinecke , Johannes Thumshirn , Christoph Hellwig From: Lee Duncan Organization: SUSE Message-ID: <56730BEB.2050007@suse.com> Date: Thu, 17 Dec 2015 11:24:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 30 On 12/14/2015 05:55 PM, Martin K. Petersen wrote: >>>>>> "Hannes" == Hannes Reinecke writes: > >>> I'm not opposed to having the module option if others (Martin?) feel >>> they need it, but generally I think it's better to keep things as >>> simple as possible. So, unless there are strong objections, I would >>> say no. > > Hannes> Agreeing with Ewan here. > > Hannes> I guess it's up to you to tell us whether you absolutely need a > Hannes> module parameter ... > > Still not a big ida fan but since the most people seem to be in favor of > this I guess I'll have to bite the bullet. > > I don't see much value in the module parameter since it will require > customers to tweak their configs and reproduce. Not worth the hassle. > Thank you Martin. I'll look at further cleaning up the host module, but I think this still much better than leaving the code as is. -- Lee Duncan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/