Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932140AbbLQTqp (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Dec 2015 14:46:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46829 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753476AbbLQTqe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Dec 2015 14:46:34 -0500
Date: Thu, 17 Dec 2015 20:46:29 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCH 17/25] perf stat report: Move csv_sep initialization
 before report command
Message-ID: <20151217194629.GA25939@krava.brq.redhat.com>
References: <1446734469-11352-1-git-send-email-jolsa@kernel.org>
 <1446734469-11352-18-git-send-email-jolsa@kernel.org>
 <20151217185707.GM19926@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151217185707.GM19926@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3146
Lines: 60

On Thu, Dec 17, 2015 at 03:57:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 05, 2015 at 03:41:01PM +0100, Jiri Olsa escreveu:
> > So we have csv_sep properly initialized before
> > report command leg.
> 
> I moved this to before "perf stat report: Process stat and stat round
> events" so that what you wrote above makes sense, i.e. after this patch
> nothing is produced by 'perf stat report' and right after the stat and
> stat round one is applied I get:
> 
>   [acme@ssdandy linux]$ perf stat report
> 
>    Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
> 
>           0.411636      task-clock (msec)         #    0.571 CPUs utilized          
>                  2      context-switches          #    0.005 M/sec                  
>                  0      cpu-migrations            #    0.000 K/sec                  
>                149      page-faults               #    0.362 M/sec                  
>          1,291,807      cycles                    #    3.138 GHz                    
>            959,632      stalled-cycles-frontend   #   74.29% frontend cycles idle   
>            703,170      stalled-cycles-backend    #   54.43% backend  cycles idle   
>            757,538      instructions              #    0.59  insns per cycle        
>                                                   #    1.27  stalled cycles per insn
>            133,293      branches                  #  323.813 M/sec                  
>      <not counted>      branch-misses              (0.00%)
> 
>        0.000720394 seconds time elapsed
> 
>   [acme@ssdandy linux]$ 
> 
> And not this ugly thing:
> 
>   [acme@ssdandy linux]$ perf stat report
> 
>    Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
> 
>           0.411636(null)    (null)task-clock (msec)         #    0.571 CPUs utilized          
>                  2(null)    (null)context-switches          #    0.005 M/sec                  
>                  0(null)    (null)cpu-migrations            #    0.000 K/sec                  
>                149(null)    (null)page-faults               #    0.362 M/sec                  
>          1,291,807(null)    (null)cycles                    #    3.138 GHz                    
>            959,632(null)    (null)stalled-cycles-frontend   #   74.29% frontend cycles idle   
>            703,170(null)    (null)stalled-cycles-backend    #   54.43% backend  cycles idle   
>            757,538(null)    (null)instructions              #    0.59  insns per cycle        
>                                                   #    1.27  stalled cycles per insn
>            133,293(null)    (null)branches                  #  323.813 M/sec                  
>      <not counted>(null)    (null)branch-misses              (0.00%)
> 
>        0.000720394 seconds time elapsed
> 
>   [acme@ssdandy linux]$

sounds good, thanks

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/