Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934133AbbLQV4F (ORCPT ); Thu, 17 Dec 2015 16:56:05 -0500 Received: from seldsegrel01.sonyericsson.com ([37.139.156.29]:11370 "EHLO SELDSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932828AbbLQV4A (ORCPT ); Thu, 17 Dec 2015 16:56:00 -0500 Date: Thu, 17 Dec 2015 13:55:53 -0800 From: Bjorn Andersson To: Stanimir Varbanov CC: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bjorn Helgaas , Srinivas Kandagatla , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Arnd Bergmann , Jingoo Han , Pratyush Anand Subject: Re: [PATCH v4 5/5] ARM: dts: ifc6410: enable pcie dt node for this board Message-ID: <20151217215553.GA4000@usrtlx11787.corpusers.net> References: <1449149725-27607-1-git-send-email-stanimir.varbanov@linaro.org> <1449149725-27607-6-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1449149725-27607-6-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 55 On Thu 03 Dec 05:35 PST 2015, Stanimir Varbanov wrote: > Enable pcie dt node and fill pcie dt node with regulator, pinctrl > and reset gpio, to use the pcie on the ifc6410 board. > > Signed-off-by: Stanimir Varbanov > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index 11ac608b6d50..f203b94ee460 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -47,6 +47,18 @@ > bias-disable; > }; > }; > + > + pcie_pins: pcie_pinmux { > + mux { > + pins = "gpio27"; > + function = "gpio"; > + }; > + conf { > + pins = "gpio27"; > + drive-strength = <12>; > + bias-disable; > + }; > + }; > }; > > rpm@108000 { > @@ -123,6 +135,10 @@ > pm8921_lvs1: lvs1 { > bias-pull-down; > }; > + > + pm8921_lvs6: lvs6 { > + bias-pull-down; > + }; Please don't duplicate the labels in the dts files. > }; > }; > Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/