Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754558AbbLQXdx (ORCPT ); Thu, 17 Dec 2015 18:33:53 -0500 Received: from gloria.sntech.de ([95.129.55.99]:50857 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbbLQXdv (ORCPT ); Thu, 17 Dec 2015 18:33:51 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Caesar Wang Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, leozwang@google.com, keescook@google.com Subject: Re: [PATCH v1 5/6] ARM: dts: add the sound codec for kylin board Date: Fri, 18 Dec 2015 00:33:47 +0100 Message-ID: <12098155.IWsPK2pU5b@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <1450362112-8075-6-git-send-email-wxt@rock-chips.com> References: <1450362112-8075-1-git-send-email-wxt@rock-chips.com> <1450362112-8075-6-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 75 Am Donnerstag, 17. Dezember 2015, 22:21:51 schrieb Caesar Wang: > Support the rt5616 codec for kylin board, but we need > enable the i2s firstly. > > Signed-off-by: Caesar Wang > --- > > arch/arm/boot/dts/rk3036-kylin.dts | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3036-kylin.dts > b/arch/arm/boot/dts/rk3036-kylin.dts index 69b1e1e..296139b 100644 > --- a/arch/arm/boot/dts/rk3036-kylin.dts > +++ b/arch/arm/boot/dts/rk3036-kylin.dts > @@ -46,6 +46,28 @@ > model = "Rockchip RK3036 KylinBoard"; > compatible = "rockchip,rk3036-kylin", "rockchip,rk3036"; > > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,name = "rockchip,rt5616-codec"; > + simple-audio-card,mclk-fs = <64>; > + simple-audio-card,widgets = > + "Microphone", "Microphone Jack", > + "Headphone", "Headphone Jack"; > + simple-audio-card,routing = > + "MIC1", "Microphone Jack", > + "MIC2", "Microphone Jack", > + "Microphone Jack", "micbias1", > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + simple-audio-card,cpu { > + sound-dai = <&i2s>; > + }; > + simple-audio-card,codec { > + sound-dai = <&rt5616>; > + }; > + }; > + > vcc_sys: vsys-regulator { > compatible = "regulator-fixed"; > regulator-name = "vcc_sys"; > @@ -261,6 +283,17 @@ > > &i2c2 { > status = "okay"; > + > + rt5616: rt5616@1b { > + #sound-dai-cells = <0>; > + compatible = "rt5616"; > + reg = <0x1b>; > + }; I don't see that codec in the asoc-tree [0]. And the compatible would of course also need to be "realtek,rt5616". [0] https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/tree/sound/soc/codecs?h=for-next > +}; > + > +&i2s { > + #sound-dai-cells = <0>; > + status = "okay"; > }; > > &lcdc { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/