Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966121AbbLRC1L (ORCPT ); Thu, 17 Dec 2015 21:27:11 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:44361 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966047AbbLRC1I (ORCPT ); Thu, 17 Dec 2015 21:27:08 -0500 Date: Fri, 18 Dec 2015 10:26:54 +0800 From: Herbert Xu To: Xin Long Cc: Phil Sutter , davem , network dev , linux-kernel@vger.kernel.org, tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org Subject: Re: rhashtable: Prevent spurious EBUSY errors on insertion Message-ID: <20151218022654.GA18495@gondor.apana.org.au> References: <1448039840-11367-1-git-send-email-phil@nwl.cc> <20151130093755.GA8159@gondor.apana.org.au> <20151130101401.GA17712@orbit.nwl.cc> <20151130101859.GA8378@gondor.apana.org.au> <20151203124129.GA5505@gondor.apana.org.au> <20151217084809.GC9239@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 19 On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: > > I'm just wondering, why do not we handle the genuine double rehash > issue inside rhashtable? i mean it's just a temporary error that a > simple retry may fix it. Because a double rehash means that someone has cracked your hash function and there is no point in trying anymore. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/