Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933572AbbLRIUB (ORCPT ); Fri, 18 Dec 2015 03:20:01 -0500 Received: from mail1.bemta14.messagelabs.com ([193.109.254.111]:22949 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933369AbbLRIT7 (ORCPT ); Fri, 18 Dec 2015 03:19:59 -0500 X-Env-Sender: Andreas.Werner@men.de X-Msg-Ref: server-10.tower-194.messagelabs.com!1450426791!8903122!1 X-Originating-IP: [80.255.6.145] X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked X-PGP-Universal: processed; by keys.men.de on Fri, 18 Dec 2015 09:19:52 +0100 Date: Fri, 18 Dec 2015 09:18:05 +0100 From: Andreas Werner To: Guenter Roeck CC: Jean Delvare , Andreas Werner , , , Subject: Re: [lm-sensors] LM90 driver and ti tmp461 detection Message-ID: <20151218081805.GC2349@awelinux> References: <20151210120856.GA27765@awelinux> <5669AB55.5030309@roeck-us.net> <20151210171231.GA28022@awelinux> <20151212110842.10e7693e@endymion.delvare> <20151215151123.GA2349@awelinux> <20151217124808.63f8f54f@endymion.delvare> <20151217145751.GA21030@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151217145751.GA21030@roeck-us.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [192.1.1.170] X-ClientProxiedBy: MEN-EX01.intra.men.de (192.168.1.1) To MEN-EX01.intra.men.de (192.168.1.1) X-EXCLAIMER-MD-CONFIG: e4841e51-7998-49c0-ba41-8b8a0e2d8962 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 34 On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote: > On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote: > > Hi Andreas, > > > > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote: > > > here is the register dump of the tmp461. > > > > Thanks. > > > > > It seemse that we really cannot detect if it is a tmp461 or a tmp451. > > > Also the magic "ID Register" offset 0xff is 0x00 for both devices. > > > > I would use register 0x16, which doesn't exist but reads 0x00 on the > > TMP451. It could in theory also read 0x00 on the TMP461 but only if > > both channels are disabled, which makes little sense. More likely at > > least one channel will be enabled so you'll have value 0x01-0x03 if > > this is a TMP461. > > > Excellent idea! > > Guenter Ok, i will implement the detection for the tm461 and also the temp calculation for setting the temperature value. Will send a patch as soon as i am done. Regards Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/