Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbbLRISk (ORCPT ); Fri, 18 Dec 2015 03:18:40 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:33899 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbbLRISj (ORCPT ); Fri, 18 Dec 2015 03:18:39 -0500 MIME-Version: 1.0 In-Reply-To: <20151218022654.GA18495@gondor.apana.org.au> References: <1448039840-11367-1-git-send-email-phil@nwl.cc> <20151130093755.GA8159@gondor.apana.org.au> <20151130101401.GA17712@orbit.nwl.cc> <20151130101859.GA8378@gondor.apana.org.au> <20151203124129.GA5505@gondor.apana.org.au> <20151217084809.GC9239@gondor.apana.org.au> <20151218022654.GA18495@gondor.apana.org.au> Date: Fri, 18 Dec 2015 16:18:38 +0800 Message-ID: Subject: Re: rhashtable: Prevent spurious EBUSY errors on insertion From: Xin Long To: Herbert Xu Cc: Phil Sutter , davem , network dev , linux-kernel@vger.kernel.org, tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 26 On Fri, Dec 18, 2015 at 10:26 AM, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: >> >> I'm just wondering, why do not we handle the genuine double rehash >> issue inside rhashtable? i mean it's just a temporary error that a >> simple retry may fix it. > > Because a double rehash means that someone has cracked your hash > function and there is no point in trying anymore. ok, get your point, is it possible to be triggered by some cases under a big stress insertion, but they are all legal cases. like we use rhash in nftables, if there are a big batch sets to insert, may this issue happen? > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/