Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbbLRJzX (ORCPT ); Fri, 18 Dec 2015 04:55:23 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33948 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbLRJzU (ORCPT ); Fri, 18 Dec 2015 04:55:20 -0500 MIME-Version: 1.0 In-Reply-To: <20151218081138.GB15968@odux.rfo.atmel.com> References: <1449840989-563-1-git-send-email-jszhang@marvell.com> <20151218081138.GB15968@odux.rfo.atmel.com> Date: Fri, 18 Dec 2015 10:55:19 +0100 Message-ID: Subject: Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator From: Ulf Hansson To: Jisheng Zhang , Ludovic Desroches Cc: linux-mmc , Ulf Hansson , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2385 Lines: 57 On 18 December 2015 at 09:11, Ludovic Desroches wrote: > Hi Ulf, Jisheng, > > On Fri, Dec 11, 2015 at 03:48:04PM +0100, Ulf Hansson wrote: >> + Ludovic (We had some discussions around this code recently as well) >> >> On 11 December 2015 at 14:36, Jisheng Zhang wrote: >> > After commit 52221610dd84 ("mmc: sdhci: Improve external VDD regulator >> > support"), for the VDD is supplied via external regulators, we ignore >> > the code to convert a VDD voltage request into one of the standard >> > SDHCI voltage levels, then program it in the SDHCI_POWER_CONTROL. This >> > brings two issues: >> > >> > 1. SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON quirk isn't handled properly any >> > more. >> > >> > 2. What's more, once SDHCI_POWER_ON bit is set, some controllers such >> > as the sdhci-pxav3 used in marvell berlin SoCs require the voltage >> > levels programming in the SDHCI_POWER_CONTROL register, even the VDD >> > is supplied by external regulator. So the host in marvell berlin SoCs >> > still works fine after the commit. However, commit 3cbc6123a93d ("mmc: >> > sdhci: Set SDHCI_POWER_ON with external vmmc") sets the SDHCI_POWER_ON >> > bit, this would make the host in marvell berlin SoCs won't work any >> > more with external vmmc. >> > >> > This patch restores the behavior when setting VDD through external >> > regulator by moving the call of mmc_regulator_set_ocr() to the end >> > of sdhci_set_power() function. >> > >> > After this patch, the sdcard on Marvell Berlin SoC boards work again. >> > >> > Signed-off-by: Jisheng Zhang >> > Fixes: 52221610dd84 ("mmc: sdhci: Improve external VDD ...") > > Reviewed-by: Ludovic Desroches > Tested-by: Ludovic Desroches > > Even if the patch sounds good for me, I wanted to test it. As planned, > with this patch, I can describe my vcc regulator without breaking the > behavior of my sdhci controller. > Okay! According to the reasoning and testing, this change seems like a good idea! I have now queued the v2 for next. Thanks! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/