Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbbLRJ5h (ORCPT ); Fri, 18 Dec 2015 04:57:37 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37017 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbbLRJ5c (ORCPT ); Fri, 18 Dec 2015 04:57:32 -0500 Subject: Re: [PATCH v4 5/5] ARM: dts: ifc6410: enable pcie dt node for this board To: Bjorn Andersson References: <1449149725-27607-1-git-send-email-stanimir.varbanov@linaro.org> <1449149725-27607-6-git-send-email-stanimir.varbanov@linaro.org> <20151217215553.GA4000@usrtlx11787.corpusers.net> Cc: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bjorn Helgaas , Srinivas Kandagatla , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Arnd Bergmann , Jingoo Han , Pratyush Anand From: Stanimir Varbanov Message-ID: <5673D885.30803@linaro.org> Date: Fri, 18 Dec 2015 11:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151217215553.GA4000@usrtlx11787.corpusers.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1674 Lines: 58 On 12/17/2015 11:55 PM, Bjorn Andersson wrote: > On Thu 03 Dec 05:35 PST 2015, Stanimir Varbanov wrote: > >> Enable pcie dt node and fill pcie dt node with regulator, pinctrl >> and reset gpio, to use the pcie on the ifc6410 board. >> >> Signed-off-by: Stanimir Varbanov >> --- >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> index 11ac608b6d50..f203b94ee460 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> @@ -47,6 +47,18 @@ >> bias-disable; >> }; >> }; >> + >> + pcie_pins: pcie_pinmux { >> + mux { >> + pins = "gpio27"; >> + function = "gpio"; >> + }; >> + conf { >> + pins = "gpio27"; >> + drive-strength = <12>; >> + bias-disable; >> + }; >> + }; >> }; >> >> rpm@108000 { >> @@ -123,6 +135,10 @@ >> pm8921_lvs1: lvs1 { >> bias-pull-down; >> }; >> + >> + pm8921_lvs6: lvs6 { >> + bias-pull-down; >> + }; > > Please don't duplicate the labels in the dts files. Sorry, I based those dts patches before [1] has been applied in -next. I will rebase this patch on top of [1]. Thanks! [1] "ARM: dts: qcom: apq8064: Declare all pm8921 regulators" -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/