Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbbLRKNa (ORCPT ); Fri, 18 Dec 2015 05:13:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36321 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbLRKN1 (ORCPT ); Fri, 18 Dec 2015 05:13:27 -0500 Date: Fri, 18 Dec 2015 11:13:24 +0100 From: Jiri Olsa To: "Wangnan (F)" Cc: acme@redhat.com, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, Jiri Olsa Subject: Re: [PATCH] tools build: Remove FEATURE-DUMP Message-ID: <20151218101324.GB670@krava.brq.redhat.com> References: <566561BA.30909@huawei.com> <1449485338-62100-1-git-send-email-wangnan0@huawei.com> <20151207135254.GC26191@krava.brq.redhat.com> <5673C6A1.2090109@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5673C6A1.2090109@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 25 On Fri, Dec 18, 2015 at 04:41:05PM +0800, Wangnan (F) wrote: SNIP > >> # features detection state. > >> FEATURE_INCLUDE_FILENAME = $(OUTPUT)FEATURE-INCLUDE$(FEATURE_USER) > >>+FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)=$(feature-$(feat))) > >>+FEATURE_DUMP_FILE := $(foreach feat,$(FEATURE_DISPLAY),$(shell touch $(FEATURE_INCLUDE_FILENAME); cat $(FEATURE_INCLUDE_FILENAME) | grep 'feature-$(feat)=')) > >hum, this ignores dwarf-post-unwind setup, I think it needs more changes > >I'll post new version > > Hi Jiri, > > What the current status of this patch and 'tools build: Introduce > features dump include makefile'? They are in my local tree for a long time. hi, I'll try to send it out next week.. I needed to factor the code a little jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/