Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbbLRKSy (ORCPT ); Fri, 18 Dec 2015 05:18:54 -0500 Received: from regular1.263xmail.com ([211.150.99.132]:37019 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbbLRKSw (ORCPT ); Fri, 18 Dec 2015 05:18:52 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <78364f8670bb8b65c3380a9b41a7bc51> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5673DD86.7010304@rock-chips.com> Date: Fri, 18 Dec 2015 18:18:46 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6.1 4/6] drm: rockchip: Support Synopsys DW MIPI DSI References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450432074-19808-1-git-send-email-zyw@rock-chips.com> In-Reply-To: <1450432074-19808-1-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 25 On 2015年12月18日 17:47, Chris Zhong wrote: > + if (drm_core_check_feature(drm, DRIVER_ATOMIC)) > + drm_connector_init(drm, &dsi->connector, > + &dw_mipi_dsi_atomic_connector_funcs, > + DRM_MODE_CONNECTOR_DSI); > + else > + drm_connector_init(drm, &dsi->connector, > + &dw_mipi_dsi_connector_funcs, > + DRM_MODE_CONNECTOR_DSI); > + Hi Chris Since only drm/rockchip use the dw_mipi, and drm/rockchip is converting to atomic API, so I think legacy connector funcs is no needed. Thanks. -- Mark Yao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/