Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbbLRLFk (ORCPT ); Fri, 18 Dec 2015 06:05:40 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:2889 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbbLRLFi (ORCPT ); Fri, 18 Dec 2015 06:05:38 -0500 Message-ID: <5673E813.2080400@huawei.com> Date: Fri, 18 Dec 2015 19:03:47 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Daniel Wagner , , , , , , , , , , , CC: , Subject: Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations References: <1450329794-161948-1-git-send-email-wangnan0@huawei.com> <56725868.6080902@bmw-carit.de> <56725B67.2010309@huawei.com> <56725E59.6090507@bmw-carit.de> <56727259.80002@bmw-carit.de> <567289D6.9050209@huawei.com> <5672BC99.4070605@bmw-carit.de> <567377D0.6080302@huawei.com> <5673C8A6.1080806@bmw-carit.de> In-Reply-To: <5673C8A6.1080806@bmw-carit.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5673E839.018A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 239c57a6f4d57561026c6499ab2ca8f2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2946 Lines: 75 On 2015/12/18 16:49, Daniel Wagner wrote: > On 12/18/2015 04:04 AM, Wangnan (F) wrote: >> On 2015/12/17 21:46, Daniel Wagner wrote: >>> On 12/17/2015 11:09 AM, Wangnan (F) wrote: >>>> On 2015/12/17 16:29, Daniel Wagner wrote: >>>>> On 12/17/2015 08:03 AM, Daniel Wagner wrote: >>>>> Patch number 2 didn't apply cleanly. >>>> When you see this, could you please have a look at: >>>> >>>> /home/wagi/src/linux/samples/bpf/libbpf/feature/test-*.make.output >>>> >>>> ? >>> test-libpython.c:1:20: fatal error: Python.h: No such file or directory >> So it is the content in test-all.make.output ? Then it is >> not a problem. It is only a fastpath which tries to check >> all features by one test. On most platform it would fail. > I see. > >> BPF related feature check is not in test-all. It is a potential >> bug, but I don't think it causes your problem. >> >> Another problem is you didn't see this in the first failure: >> >> Auto-detecting system features: >> ... libelf: [ on ] >> ... bpf: [ on ] >> >> This only happen when you already have a FEATURE-DUMP.libbpf in that >> directory and it is same as the feature check result. >> >> Could you please remove samples/bpf in your building tree and >> try again? After you see the failure, what's the content of >> >> /home/wagi/src/linux/samples/bpf/libbpf/FEATURE-* ? > I cleanup up my tree (rm samples/bpf/ and git checkout samples/bpf) and then > > $ make samples/bpf/ > CHK include/config/kernel.release > CHK include/generated/uapi/linux/version.h > CHK include/generated/utsrelease.h > CHK include/generated/bounds.h > CHK include/generated/timeconst.h > CHK include/generated/asm-offsets.h > CALL scripts/checksyscalls.sh > LD samples/bpf/built-in.o > make -C /home/wagi/src/linux/tools/lib/bpf O=/home/wagi/src/linux/samples/bpf/libbpf CFLAGS= LDFLAGS= V=1 /home/wagi/src/linux/samples/bpf/libbpf/libbpf.a > > Auto-detecting system features: > ... libelf: [ OFF ] > ... bpf: [ OFF ] That's good. This is not a magic. I guess something in your top makefile causes this feature check failure. I sent a patch on feature checker to you. It will appear as [1] soon. Could you please apply it and try again? This time you will see test-*.make.output and test-*.make.makeoutput. test-*.make.output lists your PATH, PWD and the gcc command you use for feature check. test-*.make.makeoutput is the output of 'make' itself. I think from these information we can find the root cause easier. Thank you. [1] http://lkml.kernel.org/g/1450436211-170447-1-git-send-email-wangnan0@huawei.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/