Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbbLRLfm (ORCPT ); Fri, 18 Dec 2015 06:35:42 -0500 Received: from foss.arm.com ([217.140.101.70]:39415 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbbLRLfl (ORCPT ); Fri, 18 Dec 2015 06:35:41 -0500 Message-ID: <5673EF88.80205@arm.com> Date: Fri, 18 Dec 2015 11:35:36 +0000 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Mark Rutland , "majun (F)" CC: Catalin.Marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com, jason@lakedaemon.net, tglx@linutronix.de, lizefan@huawei.com, huxinwei@huawei.com, dingtianhong@huawei.com, zhaojunhua@hisilicon.com, liguozhu@hisilicon.com, xuwei5@hisilicon.com, wei.chenwei@hisilicon.com, guohanjun@huawei.com, wuyun.wu@huawei.com, guodong.xu@linaro.org, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, usman.ahmad@linaro.org, klimov.linux@gmail.com, gabriele.paoloni@huawei.com Subject: Re: [PATCH v10 1/4] dt-binding:Documents of the mbigen bindings References: <1450353397-47668-1-git-send-email-majun258@huawei.com> <1450353397-47668-2-git-send-email-majun258@huawei.com> <20151217135247.GD13389@leverpostej> <5673683C.2080304@huawei.com> <20151218105837.GB29219@leverpostej> In-Reply-To: <20151218105837.GB29219@leverpostej> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2370 Lines: 76 On 18/12/15 10:58, Mark Rutland wrote: > On Fri, Dec 18, 2015 at 09:58:20AM +0800, majun (F) wrote: >> Hi Mark: >> >> 在 2015/12/17 21:52, Mark Rutland 写道: >>> On Thu, Dec 17, 2015 at 07:56:34PM +0800, MaJun wrote: >>>> From: Ma Jun >> [...] >>>> +- compatible: Should be "hisilicon,mbigen-v2" >>>> + >>>> +- reg: Specifies the base physical address and size of the Mbigen >>>> + registers. >>>> + >>>> +- interrupt controller: Identifies the node as an interrupt controller >>>> + >>>> +- msi-parent: Specifies the MSI controller this mbigen use. >>>> + For more detail information,please refer to the generic msi-parent binding in >>>> + Documentation/devicetree/bindings/interrupt-controller/msi.txt. >>>> + >>>> +- num-msis:Specifies the total number of interrupt this device has. >>> >>> Is this the number of pins implemented? Or the number of pins that are >>> in use? >>> >>> The latter feels like something we can derive. >> >> num-msis means the total number of pins implemented. > > Ok. In that case I think it should be: > > - num-pins: the total number of pins implemented in this Mbigen > instance. > > (with the appropriate fixups in the driver). > > With that: > > Acked-by: Mark Rutland > >>>> +- #interrupt-cells : Specifies the number of cells needed to encode an >>>> + interrupt source. The value must be 2. >>>> + >>>> + The 1st cell is hardware pin number of the interrupt.This number is local to >>>> + each mbigen chip and in the range from 0 to the maximum interrupts number >>>> + of the mbigen. >>> >>> Just to check: 0 - 63 represent the "reserved" pins, yes? >> >> Yes, you are right. >> >>> >>> Other than those questions, this looks good to me. >> >> Do i need to post a new patch to update these two questions? > > Hopefully not. > > Marc, are you happy to fold in the s/num-msis/num-pins/ change? FWIW, I'm also moving this to: Documentation/devicetree/bindings/interrupt-controller/hisilicon,mbigen-v2.txt in order to match the new documentation conventions. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/